feat(web): adds gesture 'traces' for warning/error logging #13360
+162
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate debugging cases where gestures don't work as intended, this adds sanitized logging for keystrokes resulting for gestures. These are only to be output when a relevant error or warning is emitted. This is primarily being added to facilitate investigation of #13344.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
approved these changes
Feb 27, 2025
| return undefined; | ||
| } | ||
|
|
||
| const timestamps = this.sources.map((entry => { |
There was a problem hiding this comment.
Suggested change
| const timestamps = this.sources.map((entry => { | |
| const timestamps = this.sources.map(entry => { |
| start: entry.path.stats.initialSample.t, | ||
| end: entry.path.stats.lastTimestamp | ||
| } | ||
| })); |
There was a problem hiding this comment.
Suggested change
| })); | |
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate debugging cases where gestures don't work as intended, this adds sanitized logging for keystrokes resulting for gestures. These are only to be output when a relevant error or warning is emitted. They're also pretty handy for obtaining an overview of a gesture's history during code inspection.
This is primarily being added to facilitate investigation of #13344. An example log that could result for this, though for a properly working state:
This log is ordered from "newest" to "oldest" context, with the gesture components for each ordered similarly. Note that "state 23" appears before "state 25" - they're both part of the same multitap, and "state 27" reapplied "state 23" as part of its operation (undoing "state 25", which it invalidated).
@keymanapp-test-bot skip