fix(mac): improve compliance checking #13337
Open
+204
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the evaluation of whether the current text input client is compliant by better detecting when the last compliance check has become stale. The OS does not always notify the Input Method when the client has changed and sometimes the compliance for an application varies depending on where the user is typing (for example, typing in the Chrome address bar vs. typing in the Chrome context area with a Google doc loaded).
With this change, continue doing a compliance check when we receive a key down event, but change how we determine whether the client has changed, as encapsulated in
TextApiCompliance isMatchingClient:applicationId:.Also change the property
clientto weak so theTextApiComplianceinstances do not retain the client. Add Sentry breadcrumbs to better investigate issues related to compliance.@keymanapp-test-bot skip