fix(developer): use U+0001 for deadkey markers in the debugger #13336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used U+FFFC as a marker in the debugger (for deadkeys and LDML keyboard markers), which displayed as the letters OBJ in a small dotted square. However, we switched the underlying component to RichEdit, in order to better support rendering of many scripts (EDIT has some problems). The RichEdit control silently converts U+FFFC to U+0020. I switched to U+0001 as this is handled better, but has an unfortunate missing-glyph marker. In the future, it would be better to use a non-character marker (leveraging RichEdit), but this is a much more complex change, and this fix at least matches previous functionality. Fixes: #13293
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair and
srl295
as code owners
keymanapp-test-bot
bot
added
user-test-missing
User Test ResultsTest specification and instructions Test Artifacts
|
keymanapp-test-bot
bot
added
the
user-test-required
keymanapp-test-bot
bot
removed
the
user-test-missing
darcywong00
reviewed
Feb 24, 2025
| @@ -31,6 +31,7 @@ inherited frmLdmlKeyboardDebug: TfrmLdmlKeyboardDebug | |||
| Font.Name = 'Arial' | |||
| Font.Style = [] | |||
| ParentFont = False | |||
| PlainText = True | |||
There was a problem hiding this comment.
Is this so RichEdit displays U+0001?
There was a problem hiding this comment.
No, this doesn't have any direct impact. It was inserted automatically by the Delphi development environment; it's probably not important but it matches what we specified for the component at design time.
srl295
approved these changes
Feb 24, 2025
Test ResultsI tested this issue with the attached KeymanDeveloper"18.0.198-beta-test-13336" build(25/02/2025) on Windows 10 and 11. Here I am sharing my observation.
|
keymanapp-test-bot
bot
removed
the
user-test-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used U+FFFC as a marker in the debugger (for deadkeys and LDML keyboard markers), which displayed as the letters OBJ in a small dotted square. However, we switched the underlying component to RichEdit, in order to better support rendering of many scripts (EDIT has some problems). The RichEdit control silently converts U+FFFC to U+0020. I switched to U+0001 as this is handled better, but has an unfortunate missing-glyph marker.
In the future, it would be better to use a non-character marker (leveraging RichEdit), but this is a much more complex change, and this fix at least matches previous functionality.
Fixes: #13293
User Testing
TEST_DEADKEYS: In the keyboard debugger, select a keyboard that includes deadkeys (such as sil_bengali_phonetic). Try typing keys that generate deadkeys, and verify that they display as a square box and are highlighted in the character grid below. Make sure that the deadkey rules function correctly e.g. type qa in sil_bengali_phonetic. Also try backspacing a deadkey -- both the deadkey and the preceding character should be deleted with a single keystroke (as normally, deadkeys are not visible to the end user).