Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(android): re-order host page script load so Sentry can report script load failures #13333

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

jahorton
Copy link
Contributor

Parallels #13332, though we haven't seen similar host-page Keyman Engine for Web script-loading issues for Android at this point.

User Testing

TEST_SIMPLE_APP_START: Launch the Keyman app and verify that it functions and types normally. A simple "everything looks good" check; no need to be detailed here.

…script load failures

Parallels #13332, though we haven't seen similar issues for Android at this point.
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Feb 24, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 24, 2025

@dinakaranr
Copy link

Test Results

I tested this issue with the attached Keyman"18.0.199-beta-test-13333" build(24/02/2025) on Android 14(Physical device) and Android 12(Emulator). Here I am sharing my observation.

  • TEST_SIMPLE_APP_START (Passed):
  1. Install the keyman-18.0.199.apk file.
  2. Launch the Keyman app.
  3. The "Get Started" menu appears, enable Keyman as a system keyboard and set it as the default keyboard.
  4. Navigate to the "Search the keyboard" by pressing Keyman settings --> Install Keyboard or Dictionary --> Install from keyman.com.
  5. Installed multiple language keyboards.
  6. Open the "Keyboard Picker" by pressing the "globe" key.
  7. Select another keyboard.
  8. Close the keyboard picker.
  9. Verified that the Keyman app is not closed.
  10. Verified that the selected keyboard appeared.
  11. Enter some sentences using the "EutoLatin" keyboard.
  12. Verified that the suggestion words appeared on the banner.
  13. Change the mobile view from portrait to landscape view.
  14. Verified that the Keyman keyboard appeared in default size.
  15. Change the mobile view from portrait to landscape view.
  16. Launch the Chrome browser.
  17. Navigate to the Google search box(text area)
  18. Verified that the Keyman keyboard appeared.
    It works well. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Feb 24, 2025
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants