chore(core): add unit tests to validate nul with index and context
#13311
+113
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 4 test keyboards to validate `nul` and `if` used in conjunction with `index` and `context` and corresponding references in core unit tests. Add a script to rebuild baseline keyboards using a copy of kmcomp.exe 16.0.138; this is setup and tested only on Windows (YMMV on WINE, etc). Add the 4 additional baseline test keyboards to kmcmplib unit tests for build consistency between kmcomp 16 and kmcmplib 18 (all pass). Note: two of the new Core tests currently fail. This is expected, see issue #13304. Fixes: #13303
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
core/
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair,
srl295,
ermshiperete and
rc-swag
as code owners
jahorton
approved these changes
Feb 25, 2025
ermshiperete
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 4 test keyboards to validate
nulandifused in conjunction withindexandcontextand corresponding references in core unit tests.Add a script to rebuild baseline keyboards using a copy of kmcomp.exe 16.0.138; this is setup and tested only on Windows (YMMV on WINE, etc).
Add the 4 additional baseline test keyboards to kmcmplib unit tests for build consistency between kmcomp 16 and kmcmplib 18 (all pass).
Note: two of the new Core tests will fail on this PR. This is expected, see issue #13304. The following PR, #13314, fixes the implementation so that the tests pass.
Fixes: #13303
@keymanapp-test-bot skip