Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(linux): don't crash if fcitx5-configtool can't be found #13282

Closed
ermshiperete opened this issue Feb 19, 2025 · 2 comments · Fixed by #13363
Closed

bug(linux): don't crash if fcitx5-configtool can't be found #13282

ermshiperete opened this issue Feb 19, 2025 · 2 comments · Fixed by #13363
Assignees
@ermshiperete
Labels
bug linux/
Milestone
B18S2

Comments

@ermshiperete
Copy link
Contributor

ermshiperete commented Feb 19, 2025 •
edited
Loading

It seems to be possible that fcitx5 is reported running, but fcitx5-configtool can't be found. We should catch (and ignore) the exception, or check beforehand if fcitx5-configtool is available.

Call stack:

FileNotFoundError: [Errno 2] No such file or directory: 'fcitx5-configtool'
  File "keyman_config/install_window.py", line 370, in on_install_clicked
    subprocess.run(['fcitx5-configtool'])
  File "subprocess.py", line 548, in run
    with Popen(*popenargs, **kwargs) as process:
  File "subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)

Sentry issue: KEYMAN-LINUX-7S
@ermshiperete ermshiperete added this to the B18S2 milestone Feb 19, 2025
@sentry-io Sentry.io
Copy link

sentry-io bot commented Feb 19, 2025

Sentry Issue: KEYMAN-LINUX-7S

@ermshiperete ermshiperete self-assigned this Feb 19, 2025
ermshiperete added a commit that referenced this issue Feb 27, 2025
@ermshiperete
fix(linux): ignore exception when fcitx5-configtool is not found
0fc096d 
Fixes: #13282
ermshiperete added a commit that referenced this issue Feb 27, 2025
@ermshiperete
fix(linux): ignore exception when fcitx5-configtool is not found
d90b718 
Fixes: #13282
Fixes: KEYMAN-LINUX-7S
@ermshiperete ermshiperete mentioned this issue Feb 27, 2025
Merged
@ermshiperete ermshiperete linked a pull request Feb 27, 2025 that will close this issue
fix(linux): ignore exception when fcitx5-configtool is not found #13363
Merged
@ermshiperete
Copy link
Contributor Author

Fixed by #13363

@github-project-automation github-project-automation bot moved this to Done in Keyman Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ermshiperete ermshiperete

Labels
bug linux/
Projects
Keyman
Archived in project
Milestone
B18S2
Development

Successfully merging a pull request may close this issue.

fix(linux): ignore exception when fcitx5-configtool is not found keymanapp/keyman
1 participant
@ermshiperete