Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(developer): kmc-convert: prevent processing possible circular rules of a .keylayout file 😎 #13338

Open
SabineSIL opened this issue Feb 24, 2025 · 0 comments

Comments

@SabineSIL
Copy link
Contributor

SabineSIL commented Feb 24, 2025

The structure of keylayout files allows multiple key-modifier combinations to be used one after the other.
We need to make sure they do not refer to themselves which might create circular rules while processing files like that.

Kmc-convert allows for 1,2 and 3 key-modifier combinations to be used one after the other. The use of more key-modifier combinations should be prevented

see PR#12564

@SabineSIL SabineSIL self-assigned this Feb 24, 2025
@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(developer): kmc-convert: prevent processing possible circular rules of a .keylayout file feat(developer): kmc-convert: prevent processing possible circular rules of a .keylayout file 😎 Feb 24, 2025
@SabineSIL SabineSIL moved this to Todo in Keyman Feb 24, 2025
@SabineSIL SabineSIL added this to the 19.0 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant