fix(developer): prevent double action of editor hotkeys in debugger #13345
+0
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the move to the richedit control, hotkeys such as Ctrl+V are natively managed and we no longer need to handle them separately, as this caused actions to be applied twice. Fixes: #13335
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair and
srl295
as code owners
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
approved these changes
Feb 26, 2025
| @@ -889,8 +868,6 @@ TMemoSelectionState = record | |||
| else msg.Msg := WM_KEYUP; | |||
| memo.Dispatch(msg); | |||
|
|
|||
| DoHandleShortcut(LOBYTE(dwData)); | |||
There was a problem hiding this comment.
With the move to the richedit control, hotkeys such as Ctrl+V are natively managed and we no longer need to handle them separately
Could we document this in a comment? (for maintenance)
There was a problem hiding this comment.
Is this PR sufficient? We aren't going to move away from RichEdit until we rewrite TIKE as HTML (in which case this change will be irrelevant anyway!)
mcdurdin
deleted the
fix/developer/13335-prevent-double-application-of-edit-shortcuts-in-debugger
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.202-beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to the richedit control, hotkeys such as Ctrl+V are natively managed and we no longer need to handle them separately, as this caused actions to be applied twice.
Fixes: #13335
@keymanapp-test-bot skip