Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(windows): if kmshell is "silent" don't start a Keyman update #13329

Open
rc-swag opened this issue Feb 24, 2025 · 0 comments
Open

bug(windows): if kmshell is "silent" don't start a Keyman update #13329

rc-swag opened this issue Feb 24, 2025 · 0 comments
Assignees
Milestone

Comments

@rc-swag
Copy link
Contributor

rc-swag commented Feb 24, 2025

If Keyman an update is ready to install but kmshell is in silent mode, meaning we can't ask the user if they want to Update now, then do not send handlekmshell event to the start machine which would start an install.
BUT
if the the updated is Not ready to install and in silent mode it is OK to send the handlekmsell event to the statemachine.

This sort of logic would be nice and neat inside the statemachine but with need to seperate the UI from the state machine.

@rc-swag rc-swag self-assigned this Feb 24, 2025
@rc-swag rc-swag added this to the B18S2 milestone Feb 24, 2025
rc-swag added a commit that referenced this issue Feb 24, 2025
Don't start an install of a Keyman Update if the user has not been
notified.

Fixes: #13329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant