fix(developer): include nul in offset calculations for kmw v10 compiler
#13326
+66
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
…iler The cached context comparison for v10 kmw compiler includes the `nul` statement, unlike the comparison in the earlier compiler. This difference was missed in earlier iterations including the recent patch in #13003. This patch fixes the problem for both `context(n)` and `index(store,n)` offset calculations. Fixes: #13306 Fixes: #13307 Follows: #13003
mcdurdin
force-pushed
the
fix/developer/13306-13307-include-nul-in-context-offset-kmw-v10
branch
from
8a0dcbb to
a04e977
Compare
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair and
srl295
as code owners
jahorton
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cached context comparison for v10 kmw compiler includes the
nulstatement, unlike the comparison in the earlier compiler. This difference was missed in earlier iterations including the recent patch in #13003. This patch fixes the problem for bothcontext(n)andindex(store,n)offset calculations.The earlier v9 kmw compiler is not impacted by this change.
Fixes: #13306
Fixes: #13307
Follows: #13003
@keymanapp-test-bot skip
Note: I will do some low-level tests before merging and add results as a comment.