Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): kmc-kmn kmw compiler generates an incorrect offset for nul ... > context(n) when in v10+ mode #13306

Open
mcdurdin opened this issue Feb 21, 2025 · 0 comments · May be fixed by #13326
Open

bug(developer): kmc-kmn kmw compiler generates an incorrect offset for nul ... > context(n) when in v10+ mode #13306

mcdurdin opened this issue Feb 21, 2025 · 0 comments · May be fixed by #13326
Assignees
@mcdurdin
Labels
bug developer/
Milestone
B18S2

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Feb 21, 2025 •
edited
Loading 

nul any(cons) + 'b' > '2' context(2)

See analysis in #13276 (comment) (we will need new unit tests to verify this also)
@mcdurdin mcdurdin changed the title Correct KMW compiler's emission of KIO offset for v10+ mode only bug(developer): kmc-kmn kmw compiler generates an incorrect offset for context(n) when in v10+ mode Feb 21, 2025
@mcdurdin mcdurdin self-assigned this Feb 21, 2025
@mcdurdin mcdurdin added this to the B18S2 milestone Feb 21, 2025
@mcdurdin mcdurdin moved this to Todo in Keyman Feb 21, 2025
@mcdurdin mcdurdin changed the title bug(developer): kmc-kmn kmw compiler generates an incorrect offset for context(n) when in v10+ mode bug(developer): kmc-kmn kmw compiler generates an incorrect offset for nul ... > context(n) when in v10+ mode Feb 21, 2025
@mcdurdin mcdurdin mentioned this issue Feb 21, 2025
Open
3 tasks
mcdurdin added a commit that referenced this issue Feb 23, 2025
@mcdurdin
fix(developer): include nul in offset calculations for kmw v10 comp…
8a0dcbb 
…iler

The cached context comparison for v10 kmw compiler includes the `nul`
statement, unlike the comparison in the earlier compiler. This
difference was missed in earlier iterations including the recent patch
in #13003. This patch fixes the problem for both `context(n)` and
`index(store,n)` offset calculations.

Fixes: #13306
Fixes: #13307
Follows: 13003
@mcdurdin mcdurdin linked a pull request Feb 23, 2025 that will close this issue
Open
mcdurdin added a commit that referenced this issue Feb 23, 2025
@mcdurdin
fix(developer): include nul in offset calculations for kmw v10 comp…
a04e977 
…iler

The cached context comparison for v10 kmw compiler includes the `nul`
statement, unlike the comparison in the earlier compiler. This
difference was missed in earlier iterations including the recent patch
in #13003. This patch fixes the problem for both `context(n)` and
`index(store,n)` offset calculations.

Fixes: #13306
Fixes: #13307
Follows: #13003
@mcdurdin mcdurdin linked a pull request Feb 23, 2025 that will close this issue
fix(developer): include nul in offset calculations for kmw v10 compiler #13326
Open
@mcdurdin mcdurdin moved this from Todo to In Progress in Keyman Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug developer/
Projects
Keyman
Status: In Progress
Milestone
B18S2
Development

Successfully merging a pull request may close this issue.

fix(developer): include nul in offset calculations for kmw v10 compiler keymanapp/keyman
1 participant
@mcdurdin