fix(core): include nul in context offset calculations in kmx processor
#13314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Two separate bugs addressed, with `index()` references and with `context()` references -- both have the same root cause, of not taking `nul` at the start of the context into account (as `nul` is not included in the `m_miniContext` member, being a non-character). We already fixed this issue for `if()` quite a long time ago, and some of the same patterns can be with `m_miniContextIfLen` for example. Fixes: #13304 Fixes: #13316
mcdurdin
force-pushed
the
fix/core/13304-include-nul-in-context-offset-calculations
branch
from
59254ba to
b973bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate bugs addressed, with
index()references and withcontext()references -- both have the same root cause, of not takingnulat the start of the context into account (asnulis not included in them_miniContextmember, being a non-character). We already fixed this issue forif()quite a long time ago, and some of the same patterns can be seen withm_miniContextIfLenfor example.Fixes: #13304
Fixes: #13316
@keymanapp-test-bot skip