Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): debugger appears to get mixed up on CRLF #13292

Open
mcdurdin opened this issue Feb 20, 2025 · 0 comments · May be fixed by #13334
Open

bug(developer): debugger appears to get mixed up on CRLF #13292

mcdurdin opened this issue Feb 20, 2025 · 0 comments · May be fixed by #13334
Assignees
@mcdurdin
Labels
bug developer/
Milestone
B18S2

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Feb 20, 2025 •
edited
Loading

20250220-0618-30.0624208.mp4

Keyman Developer 18.0.190-beta

When Enter is pressed, CRLF is inserted, but tracking of the cursor position doesn't work correctly; Backspace does not delete CRLF because cursor appears to be between CR and LF. Del when on left deletes both as expected.
@mcdurdin mcdurdin added this to the B18S3 milestone Feb 20, 2025
@mcdurdin mcdurdin self-assigned this Feb 20, 2025
mcdurdin added a commit that referenced this issue Feb 24, 2025
@mcdurdin
fix(developer): handle line breaks in debugger correctly
3c86ac3 
The debugger memo takes input with \n but internally represents this as
\r\n, so we need to strip out \r in order to track caret position
correctly.

Fixes: #13292
@mcdurdin mcdurdin linked a pull request Feb 24, 2025 that will close this issue
Open
@mcdurdin mcdurdin moved this to In Progress in Keyman Feb 24, 2025
@mcdurdin mcdurdin modified the milestones: B18S3, B18S2 Feb 24, 2025
@mcdurdin mcdurdin linked a pull request Feb 24, 2025 that will close this issue
fix(developer): handle line breaks in debugger correctly #13334
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug developer/
Projects
Keyman
Status: In Progress
Milestone
B18S2
Development

Successfully merging a pull request may close this issue.

fix(developer): handle line breaks in debugger correctly keymanapp/keyman
1 participant
@mcdurdin