Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Localize strings on keyboards details 📡 #524

Draft
wants to merge 4 commits into
base: feat/localize/keyboard-search
Choose a base branch
from
Draft

feat: Localize strings on keyboards details 📡 #524

wants to merge 4 commits into from
+633 −49

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Dec 19, 2024 •
edited
Loading

Follows #521 for #384

This uses Locale.php to get the localized strings for the keyboard details page.

A few notes:

  • The keyboard descriptions remain in English because the content comes from keyboard info in api.keyman.com
  • The "Search" button image is in English

Screenshots

khmer_angkor (details in French)

http://keyman.com.localhost/keyboards/khmer_angkor?lang=fr-FR

khmer_angkor-FR

cs-pinyin (obsolete keyboard, details in Spanish)

http://keyman.com.localhost/keyboards/cs-pinyin?lang=es-ES

cs-pinyin-ES

sil_ipa (details in English for reference)

http://keyman.com.localhost/keyboards/sil_ipa?lang=en

sil_ipa-EN

@darcywong00 darcywong00 added this to the A18S17 milestone Dec 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S17, A18S18 Dec 21, 2024
@darcywong00 darcywong00 modified the milestones: A18S18, A18S19 Jan 6, 2025
@darcywong00 darcywong00 requested a review from mcdurdin January 16, 2025 04:03
@darcywong00 darcywong00 modified the milestones: A18S19, A18S20 Jan 18, 2025
Base automatically changed from feat/localize/keyboard/index to feat/localize/keyboard-search January 20, 2025 04:03
@darcywong00 darcywong00 marked this pull request as draft January 20, 2025 04:04
@darcywong00 darcywong00 marked this pull request as ready for review January 20, 2025 08:30
@darcywong00 darcywong00 marked this pull request as draft January 23, 2025 03:33
@darcywong00 darcywong00 force-pushed the feat/localize/keyboard/details branch from ceeec0f to f84266e Compare January 27, 2025 02:00
@darcywong00 darcywong00 marked this pull request as ready for review January 27, 2025 03:15
@darcywong00
Copy link
Contributor Author

I had force-pushed to bring in the changes from master --> staging --> underlying feat/localize/keyboard-search base branch.

@darcywong00 darcywong00 modified the milestones: A18S20, B18S1 Feb 1, 2025
@darcywong00 darcywong00 marked this pull request as draft February 3, 2025 01:49
@darcywong00 darcywong00 force-pushed the feat/localize/keyboard/details branch from c473b44 to 7f3d7eb Compare February 3, 2025 02:48
@darcywong00 darcywong00 marked this pull request as ready for review February 3, 2025 02:48
@darcywong00 darcywong00 modified the milestones: B18S1, B18S2 Feb 15, 2025
@darcywong00 darcywong00 marked this pull request as draft February 17, 2025 07:38
@darcywong00 darcywong00 modified the milestones: B18S2, 19.0 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin Awaiting requested review from mcdurdin

Assignees
No one assigned
Labels
staging
Projects
Keyman
Status: In Progress
Milestone
19.0
Development

Successfully merging this pull request may close these issues.
1 participant
@darcywong00