Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .kvks font info for 19 projects #3363

Merged
merged 15 commits into from
Feb 27, 2025
Merged

Conversation

DavidLRowe
Copy link
Contributor

No description provided.

@DavidLRowe
Copy link
Contributor Author

From the original list in #3349 , 43 projects were fixed in #3358 and 17 in # 3362. An additional 19 are fixed in this PR. For the remaining projects in the list:

  • tengwar_quenya seems to have changed the fonts so that .kvks and .kps match, so no further change is needed
  • imperial_aramaic is an LDML keyboard. There is no .kvks file. Not sure how it got in the list. It seems that no change is needed.
  • galaxie_hebrew_mnemonic is the final keyboard project with a font conflict. It will be treated in another PR.

@LornaSIL
Copy link
Contributor

I don't think himyarit_musnad should change the .kvks font.
Desktop needs to use the non Arabic font:
image
The mobile layout uses an Arabic font for the hints. I'm not sure what those settings should be:
image
Maybe this setting <OSKFont>NotoNaskhArabic-Regular.ttf</OSKFont> in the .kps file should change to the SultanMusnad font?

Change to Global
Change to Global
@LornaSIL
Copy link
Contributor

Should rohingya_arab.kpj be in the PR? You updated the keyboard yesterday (but didn't update the format to v17)

@DavidLRowe
Copy link
Contributor Author

Restoring inadvertent change to rohingya_arab.
Removing changes to himyarit_musnad, so they can be addressed in a separate PR.

Copy link
Contributor

@LornaSIL LornaSIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for all your hard work on this!

@LornaSIL LornaSIL merged commit bb94ec5 into keymanapp:master Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants