[greek_polytonic_win_macstyle] initial submission of Greek Polytonic Windows keybo…

[alevatri]

This keyboard is based on the Windows 10 native Greek Polytonic kbd but adds the functionality of combining deadkeys as in the native Mac OSX keyboard, allowing a smooth switch between platforms for Mac users

[keyman-server]

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

[alevatri]

Ready for review

[LornaSIL]

Thanks for your pull request! I do have quite a few comments which is quite normal for a first pull request to the Keyman keyboards so don't be discouraged.

The folder name must match the filenames. So, the foldername is greek_polytonic_win_macstyle, thus all the keyboard related files must be renamed to (please do not keep the kbdhelpt name as that makes it seem like it's the keyboard from Windows:

• greek_polytonic_win_macstyle.kpj
• greek_polytonic_win_macstyle.kmn
• greek_polytonic_win_macstyle.ico
• greek_polytonic_win_macstyle.kps
• greek_polytonic_win_macstyle.kvks

You'll unfortunately need to change all the references to those files within the files. For instance:
store(&VISUALKEYBOARD) 'kbdhept.kvks' would change to `store(&VISUALKEYBOARD) 'greek_polytonic_win_macstyle.kvks'. That will be the case in the kmn and kps.

We do not wish any of the compiled files to be submitted. Also, there's a temporary .user file. So, all of these files should be deleted.

• build\kbdhelpt.kmp
• build\kbdhelpt.js
• build\kbdhelpt.kmx
• build\kbdhelpt.kvk
• kbdhept.kpj.user

The compiled files will be built by our online system, so the references to the compiled files in the .kps will still work.

• In the .kmn file you could change store(&TARGETS) 'windows' to `store(&TARGETS) 'desktop web'
• When I compile the .kmn there are some warnings. I looked at the first one and it seems to be a duplicate rule. You may want to review those warnings and fix them since it may prevent the keyboard from working as you wish.

kbdhept.kmn:398 - hint KM020AE: This rule will never be matched as another rule takes precedence Overridden by rule on line 395
kbdhept.kmn:400 - hint KM020AE: This rule will never be matched as another rule takes precedence Overridden by rule on line 396
kbdhept.kmn:401 - hint KM020AE: This rule will never be matched as another rule takes precedence Overridden by rule on line 396
kbdhept.kmn:402 - hint KM020AE: This rule will never be matched as another rule takes precedence Overridden by rule on line 399
kbdhept.kmn:413 - hint KM020AE: This rule will never be matched as another rule takes precedence Overridden by rule on line 411
kbdhept.kmn:415 - hint KM020AE: This rule will never be matched as another rule takes precedence Overridden by rule on line 412
kbdhept.kmn:416 - hint KM020AE: This rule will never be matched as another rule takes precedence Overridden by rule on line 414

Lastly, the documenation is sparse. You could updated the README.md, readme.htm, and welcome.htm to include the description you included in the .kps file. It would certainly be useful to describe how to use the keyboard in the welcome.htm file. Otherwise users will not know what deadkeys to use with which character to get some result.

For the welcome.htm file take a look at this one and perhaps model it after that: https://github.com/keymanapp/keyboards/tree/master/release/basic/basic_kbdhept. Of course, you'ld need to update it for the macos changes you made.