Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wakhi] Added Wakhi keyboard (Arabic Script) #3352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChristopherFio
Copy link

Added a keyboard for Wakhi (wbl). There is already an anglicized Wakhi keyboard in the repository, but this keyboard is for Arabic script.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@LornaSIL
Copy link
Contributor

Thanks for this keyboard PR! There are a few things I noticed that need fixing. I haven't had time to do a thorough review, but here's the first bit:

  • The readme.htm and welcome.htm appear to be the same. Generally, the readme.htm can be a very simple html file that just includes the general description of the keyboard "This keyboard is for the Wakhi language using the Arabic script in xxx country." Or maybe say "This is a QWERTY-based..." or "This is a typewriter-based..." or whatever. That is what shows up when you double-click on a .kmp. The welcome.htm will show up at the end of installing the keyboard with the whole table layout of the keyboard.
  • The `keyboard_info file is no longer needed to be committed. The same information in that file should now be in the .kps file with a similar description (on the Details tab I think). That will show up on the keyboard home page so people will know if that's the keyboard they want to use.
  • The LICENSE.md requires the word "Copyright" on the copyright line, so Copyright © 2025 Samar. Also, LICENSE.md file should be included in the list of files in the .kps file. Then, it should be selected in the Details tab.

image

Have you looked at the above keyboard? If this keyboard you are submitting is a more official layout, I'd kind of like you to fill in the Related packages section:
image

Type in rac_wakhi and select the "Deprecated" button. (However, if you aren't sure, don't do this step.)

  • There are a lot of copyright years in different places. At this point putting the year(s) in the LICENSE.md is our preferred location and we prefer to leave the year off everywhere else. That way a bunch of places don't need updating every time the keyboard is updated.

@LornaSIL LornaSIL changed the title Added Wakhi keyboard (Arabic Script) [wakhi] Added Wakhi keyboard (Arabic Script) Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants