refactor: remove use of old $TestServer variable #1894
+20
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed $site_securetavultesoft and $downloadsDomain. Fixes: #1870
darcywong00
reviewed
Feb 25, 2025
| @@ -81,8 +82,7 @@ function get_kmwbuild() | |||
| case 2: | |||
| return "2.0.473"; | |||
| default: | |||
| global $TestServer; | |||
| if($TestServer) { | |||
| if(KeymanHosts::Instance()->Tier() != KeymanHosts::TIER_PRODUCTION) { | |||
There was a problem hiding this comment.
I only saw $TestServer get initialized to false in servervars.php.
Would we ever check TIER_TEST?
There was a problem hiding this comment.
$TestServer was closer to staging -- it derives from when we had a 'test server' hosting tavultesoft's websites years and years ago. It wasn't used for automated tests. I don't think we need to check TIER_TEST here -- this code needs refactoring and rewrite one day because it's very old and the values are really out of date!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed $site_securetavultesoft and $downloadsDomain.
Fixes: #1870