Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return full GitHub ref for single-repo keyboards #260

Open
mcdurdin opened this issue Oct 28, 2024 · 0 comments
Open

feat: return full GitHub ref for single-repo keyboards #260

mcdurdin opened this issue Oct 28, 2024 · 0 comments
Labels
Milestone

Comments

@mcdurdin
Copy link
Member

Currently the keyboard API always returns the short form of the GitHub ref, e.g. release/sil/sil_ipa in the sourcePath prop. However, as we now support remote repositories, we should update the sourcePath prop to allow for arbitrary GitHub repos, paths, and refs.

This will require changes in a number of places:

  • keyman.com
  • api.keyman.com
  • kmc-keyboard-info
  • kmc-model-info
  • kmc-package, potentially?
  • kmc-copy (getKeyboardSourceFromKeymanCloud)
  • schemas, database, potentially
@mcdurdin mcdurdin added the feat label Oct 28, 2024
@mcdurdin mcdurdin added this to the 19.0 milestone Oct 28, 2024
@mcdurdin mcdurdin added this to Keyman Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant