Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: stop words prevent some keyboards searches from returning results #178

Open
mcdurdin opened this issue Feb 16, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mcdurdin
Copy link
Member

One thing I noticed: if I search for the keyboard on keyman, there are zero search results if I include more than one word.
Let me show you what I mean.
The search results for just the first word: https://keyman.com/keyboards?q=aleph
The search results for the first two words: https://keyman.com/keyboards?q=aleph%20with
Can this be fixed?

This turns out to be an oddity in SQL Server Full Text Search which we haven't struck with other keyboards. 'With' is a 'stop word', and so it gets ignored in a phrase search. This does feel a little broken. It's possible to disable stop words; we'll think about doing that.

Originally posted by @mcdurdin in keymanapp/keyboards#2148 (comment)

@mcdurdin mcdurdin added the bug Something isn't working label Feb 16, 2023
@mcdurdin
Copy link
Member Author

To fix this, we can disable stop words with:

alter fulltext index on k1.t_keyboard set stoplist = off

But we should verify that we don't end up with other unexpected results. It may be okay, but it means that words like 'a' and 'the' will be part of the search, which would be less than helpful.

An alternative would be to also do a substring match instead of a fulltext match.

@mcdurdin mcdurdin added this to the Future milestone Feb 16, 2023
@mcdurdin mcdurdin modified the milestones: Future, A18S7 Jul 5, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@mcdurdin mcdurdin self-assigned this Aug 12, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@darcywong00 darcywong00 modified the milestones: A18S9, A18S10 Aug 31, 2024
@mcdurdin mcdurdin modified the milestones: A18S10, A18S20 Sep 2, 2024
@mcdurdin mcdurdin added this to Keyman Nov 25, 2024
@mcdurdin mcdurdin modified the milestones: A18S20, 19.0 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants