Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Indicate if a test was rerun #8

Open
1 task
sprt opened this issue Oct 9, 2024 · 3 comments
Open
1 task

dashboard: Indicate if a test was rerun #8

sprt opened this issue Oct 9, 2024 · 3 comments

Comments

@sprt
Copy link
Collaborator

sprt commented Oct 9, 2024

Context:
Sometimes a nightly/PR workflow is rerun manually (because some test may be flaky and a retry may succeed). In the dashboard we want to display this info, and not just show the latest run.

Challenges:

  • The API might not let us fetch that data, TBD.

Acceptance criteria:

  • Ideally, in the UI instead of showing one ✅ or ❌, we show as many icons as there were runs of that specific test
    • For example, 2 failures and 1 success = ❌❌✅
    • Note: it could be that the entire testsuite is rerun, or that only one or a few specific tests are rerun, make sure you handle all cases

Known limitations:

  • We're still only fetching the data every 24 hours, so the data may still be stale. This is OK, as long as we're capturing ALL previous runs whenever data fetching happens.
@sprt sprt converted this from a draft issue Oct 9, 2024
@afinn12
Copy link
Contributor

afinn12 commented Oct 23, 2024

Code in: PR #22

Description

  • Rerun column added to table that counts the total number of times the job/check was reran

  • Tooltip menu that displays the results for each rerun on hover

  • Split fetch scripts for nightly/PR data

  • Added yaml for PR fetch script

  • Added triggers to both yamls on pushes to main (data pulled again if new data is needed in changes to files)

  • Also added authentication

    • To to use, put token in .env file
    • TODO: Make secret so fetch files still work in prod
  • TODO: Include rerun stats in column stats? (i.e. fails, skips)

    • TODO: Even if all tests fail/pass, not added to fails/skips (suggests a pass)
  • TODO: Also, given the nightly view picture, note that one job was rerun 5 times and one was rerun 4 times. Should the rerun count be 9 (5+4), or 7 (4+3), since runs = 9? Right now, sets reruns as 9 in this scenario.

  • TODO: Only get PRs with ok-to-test label (so keep pulling closed PRs until get 10 with that label)

Nightly View

image

PR View

image

@sprt
Copy link
Collaborator Author

sprt commented Nov 13, 2024

Just dump PR into official repo

afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 18, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 18, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 18, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <[email protected]>
@sprt
Copy link
Collaborator Author

sprt commented Nov 25, 2024

#30

afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added code to get rerun information to both fetch scripts.
Display the reruns as a superscript in the rowExpansionTemplate with the result/URL.

Fixes: kata-containers#8

Signed-off-by: Anna Finn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants