Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type annotation lacking/ maybe also add docstrings. #69

Open
BartDenOuden opened this issue May 2, 2024 · 0 comments
Open

type annotation lacking/ maybe also add docstrings. #69

BartDenOuden opened this issue May 2, 2024 · 0 comments

Comments

@BartDenOuden
Copy link

I think micrograd.nn would be easier to understand if the function signatures have type annotation. The backwards compatability of type annotation is limited, but it seems likely very few people will use micrograd with python < 3.8. I'm happy to help with this.

Also docstrings might be helpful for people studying the code.

I followed 'The spelled-out intro to neural networks and backpropagation: building micrograd' on YouTube and am grateful to Andrej for making this. Learned al lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant