Skip to content

Commit f9fd383

Browse files
committed
kvm: fix typo in create vm-snapshot
1 parent dd638ff commit f9fd383

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

kvirt/cli.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -4283,7 +4283,7 @@ def cli():
42834283

42844284
vmsnapshotdelete_desc = 'Delete Snapshot Of Vm'
42854285
vmsnapshotdelete_parser = delete_subparsers.add_parser('vm-snapshot', description=vmsnapshotdelete_desc,
4286-
help=vmsnapshotdelete_desc)
4286+
help=vmsnapshotdelete_desc, aliases=['snapshot'])
42874287
vmsnapshotdelete_parser.add_argument('-n', '--name', help='vm name', required=True, metavar='VMNAME')
42884288
vmsnapshotdelete_parser.add_argument('snapshot')
42894289
vmsnapshotdelete_parser.set_defaults(func=snapshotdelete_vm)
@@ -4871,7 +4871,7 @@ def cli():
48714871

48724872
vmsnapshotrevert_desc = 'Revert Snapshot Of Vm'
48734873
vmsnapshotrevert_parser = revert_subparsers.add_parser('vm-snapshot', description=vmsnapshotrevert_desc,
4874-
help=vmsnapshotrevert_desc, aliases=['vm'])
4874+
help=vmsnapshotrevert_desc, aliases=['snapshot'])
48754875
vmsnapshotrevert_parser.add_argument('-n', '--name', help='vm name', required=True, metavar='VMNAME')
48764876
vmsnapshotrevert_parser.add_argument('snapshot')
48774877
vmsnapshotrevert_parser.set_defaults(func=snapshotrevert_vm)

kvirt/providers/kvm/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1494,8 +1494,8 @@ def create_snapshot(self, name, base):
14941494
return {'result': 'failure', 'reason': f"Snapshot {name} already exists"}
14951495
if vm.isActive() == 0:
14961496
memoryxml = ''
1497-
else:
1498-
memoryxml = "<memory snapshot='internal'/>"
1497+
memory_snapshot = 'internal' if vm.isActive() == 0 else 'no'
1498+
memoryxml = f"<memory snapshot='{memory_snapshot}'/>"
14991499
snapxml = """<domainsnapshot>
15001500
<name>%s</name>
15011501
%s

0 commit comments

Comments
 (0)