New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement in tag names with req.params is not useful #25

Open

kapouer opened this issue Jul 5, 2018 · 1 comment

Owner

kapouer commented Jul 5, 2018

It just doesn't match how upcache tags are set w.r.t. express middlewares.

It would be more useful to configure upcache.tag with some filter(name, req) function.

Owner Author

kapouer commented Mar 11, 2019

Example:
https://github.com/pageboard/server/blob/c0ca8dee8a1e5e6ea77fbcc407198a2a7b3c76c8/packages/cache/index.js#L16
Express "params" is useful for a single route, but tag usually applies to many routes at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment