Start following PSR-12 coding standard

Author: jwilsson

CONTRIBUTING.md

@@ -16,7 +16,7 @@ Please submit all your bug reports, feature requests and pull requests here but
 If you have an idea for a new feature, please file an issue first to see if it fits the scope of this project. That way no one's time needs to be wasted.
 
 ## Coding Guidelines
-We follow the coding standards outlined in [PSR-1](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md) and [PSR-2](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md). Please follow these guidelines when committing new code.
+We follow the coding standards outlined in [PSR-1](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md) and [PSR-12](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide.md). Please follow these guidelines when committing new code.
 
 In addition to the PSR guidelines we try to adhere to the following points:
 * We order all methods by visibility and then alphabetically, `private`/`protected` methods first and then `public`. For example:

phpcs.xml

@@ -1,4 +1,4 @@
 <?xml version="1.0"?>
 <ruleset>
-  <rule ref="PSR2"/>
+  <rule ref="PSR12"/>
 </ruleset>

src/Request.php

@@ -1,13 +1,14 @@
 <?php
+
 namespace SpotifyWebAPI;
 
 class Request
 {
-    const ACCOUNT_URL = 'https://accounts.spotify.com';
-    const API_URL = 'https://api.spotify.com';
+    public const ACCOUNT_URL = 'https://accounts.spotify.com';
+    public const API_URL = 'https://api.spotify.com';
 
-    const RETURN_ASSOC = 'assoc';
-    const RETURN_OBJECT = 'object';
+    public const RETURN_ASSOC = 'assoc';
+    public const RETURN_OBJECT = 'object';
 
     protected $curlOptions = [];
     protected $lastResponse = [];
@@ -256,12 +257,11 @@ public function send($method, $url, $parameters = [], $headers = [])
         if (preg_match('/^HTTP\/1\.\d 200 Connection established$/', $headers) === 1) {
             list($headers, $body) = explode("\r\n\r\n", $body, 2);
         }
-        
+
         // Skip the first set of headers for the informal Continue header
         if (preg_match('/^HTTP\/1\.\d 100 Continue$/', $headers) === 1) {
             list($headers, $body) = explode("\r\n\r\n", $body, 2);
         }
-        
 
         $status = (int) curl_getinfo($ch, CURLINFO_HTTP_CODE);
         $headers = $this->parseHeaders($headers);

src/Session.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace SpotifyWebAPI;
 
 class Session

src/SpotifyWebAPI.php

@@ -1,10 +1,11 @@
 <?php
+
 namespace SpotifyWebAPI;
 
 class SpotifyWebAPI
 {
-    const RETURN_ASSOC = 'assoc';
-    const RETURN_OBJECT = 'object';
+    public const RETURN_ASSOC = 'assoc';
+    public const RETURN_OBJECT = 'object';
 
     protected $accessToken = '';
     protected $lastResponse = [];

src/SpotifyWebAPIAuthException.php

@@ -1,12 +1,13 @@
 <?php
+
 namespace SpotifyWebAPI;
 
 // Extends from SpotifyWebApiException for backwards compatibility
 class SpotifyWebAPIAuthException extends SpotifyWebAPIException
 {
-    const INVALID_CLIENT = 'Invalid client';
-    const INVALID_CLIENT_SECRET = 'Invalid client secret';
-    const INVALID_REFRESH_TOKEN = 'Invalid refresh token';
+    public const INVALID_CLIENT = 'Invalid client';
+    public const INVALID_CLIENT_SECRET = 'Invalid client secret';
+    public const INVALID_REFRESH_TOKEN = 'Invalid refresh token';
 
     /**
      * Returns whether the exception was thrown because of invalid credentials.

src/SpotifyWebAPIException.php

@@ -1,10 +1,11 @@
 <?php
+
 namespace SpotifyWebAPI;
 
 class SpotifyWebAPIException extends \Exception
 {
-    const TOKEN_EXPIRED = 'The access token expired';
-    const RATE_LIMIT_STATUS = 429;
+    public const TOKEN_EXPIRED = 'The access token expired';
+    public const RATE_LIMIT_STATUS = 429;
 
     /**
      * The reason string from the request's error object.