Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subissue: Fix & add E2E tests for new chat commands framework #179

Open
dlqqq opened this issue Feb 17, 2025 · 1 comment
Open

Subissue: Fix & add E2E tests for new chat commands framework #179

dlqqq opened this issue Feb 17, 2025 · 1 comment
Labels
enhancement New feature or request scope:chat-commands

Comments

@dlqqq
Copy link
Member

dlqqq commented Feb 17, 2025 •
edited by brichet
Loading

Problem

#161 broke several E2E tests for the old autocomplete framework, and lacks E2E tests for the new chat commands framework.

Proposed Solution

Update & fix all E2E tests pertaining to chat commands before Jupyter Chat v1.0.0.

Additional context

This isn't urgent as long as Jupyter Chat is still on major version v0.x. I'm not aware of any package other than Jupyter AI that is consuming this as a dependency.
@dlqqq dlqqq added the enhancement New feature or request label Feb 17, 2025
@dlqqq dlqqq mentioned this issue Feb 17, 2025
Merged
@dlqqq
Copy link
Member Author

dlqqq commented Feb 17, 2025

Old autocompletion tests which we should port: https://github.com/jupyterlab/jupyter-chat/blob/73512c16a6c602b81f873ecf9a3c20cb73cefd94/ui-tests/tests/autocompletion.spec.ts

@dlqqq dlqqq removed this from Jupyter AI Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request scope:chat-commands
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlqqq