-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct minimum versions in dependency version ranges #1272
Conversation
The latest CI failure is being caused by |
One issue is that the minimum dependencies job is now taking 20+ minutes. I think the runner may be struggling with memory use when trying to resolve the dependency set, since network downloads of PyPI packages shouldn't take this long. |
I found a couple more issues with our dependencies that may be causing this job to take forever:
|
The |
Failed after 55 minutes (!): https://github.com/jupyterlab/jupyter-ai/actions/runs/13775086781/job/38522465409?pr=1272 |
f57f1f8
to
13a43dd
Compare
Looks like bumping |
2d5d6f5
to
3ff82b2
Compare
3ff82b2
to
8f4cd5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good and the CI is also passing with these changes. Thanks for sorting out these dependency issues!
@krassowski Thank you for contributing to
Thanks to your contributions, our minimum dependency versions will now be correct & verifiable (as of v2.30.0+). |
@meeseeksdev please backport to 2.x |
…cy version ranges) (#1275) * Backport PR #1272: Correct minimum versions in dependency version ranges * loosen jupyter_server version range for 2.x --------- Co-authored-by: David L. Qiu <[email protected]>
Thank you for the work here, I appreciate it was a deep hole! The most important thing is it will help to catch some issues when using a function from a new version of a package and forgetting to bump the dependency constraint. |
Description
Python Tests / Unit tests (Python 3.9, minimum dependencies)
workflow, currently failing on CI.Details
typing_extensions
andaiosqlite
.traitlets>=5.0
totraitlets>=5.6
to match JupyterLab 4's dependencies.jupyter_server>=1.6
tojupyter_server>=2.11.1
to matchjupyter_server_ydoc>=3
dependencies.jupyter_server>=2.4
to match JupyterLab 4's dependencies.click>=8.0.0
toclick>=8.1.0
.click==8.0.0
was released almost 4 years ago and is a very common dependency. Bumping this floor speeds up minimum versions tests in CI.pydantic>=2.0.0
topydantic>=2.10.0
.pydantic<2.10.0
fails with Jupyter AI, since it raises a "protected namespaces" error due to our usage of amodel_id
attribute: https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.protected_namespacesRemovesimportlib_metadata
package, as theimportlib.metadata
module is now part of the standard library in Python 3.8+.entry_points().select(...)
fails in Python 3.9, since the API wasn't finalized until Python 3.10.