Skip to content

Commit 23b4434

Browse files
authored
Fix respecting serverapp.terminals_enabled (#91)
Fixes #85
1 parent a368582 commit 23b4434

File tree

1 file changed

+5
-0
lines changed
  • jupyter_server_terminals

1 file changed

+5
-0
lines changed

jupyter_server_terminals/app.py

+5
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ class TerminalsExtensionApp(ExtensionApp):
3636

3737
def initialize_settings(self) -> None:
3838
"""Initialize settings."""
39+
if not self.serverapp.terminals_enabled:
40+
return
3941
self.initialize_configurables()
4042
self.settings.update(
4143
{"terminals_available": True, "terminal_manager": self.terminal_manager}
@@ -71,6 +73,9 @@ def initialize_configurables(self) -> None:
7173

7274
def initialize_handlers(self) -> None:
7375
"""Initialize handlers."""
76+
if not self.serverapp.terminals_enabled:
77+
# Checking self.terminals_available instead breaks enabling terminals
78+
return
7479
self.handlers.append(
7580
(
7681
r"/terminals/websocket/(\w+)",

0 commit comments

Comments
 (0)