Move string-based argument conversion tests to platform-test

Author: scordio

jupiter-tests/src/test/java/org/junit/jupiter/params/converter/DefaultArgumentConverterTests.java

@@ -183,7 +183,7 @@ void throwsExceptionOnInvalidStringForPrimitiveTypes() {
 	}
 
 	@Test
-	void throwsExceptionWhenImplicitConverstionIsUnsupported() {
+	void throwsExceptionWhenImplicitConversionIsUnsupported() {
 		assertThatExceptionOfType(ArgumentConversionException.class) //
 				.isThrownBy(() -> convert("foo", Enigma.class)) //
 				.withMessage("No built-in converter for source type java.lang.String and target type %s",

platform-tests/src/test/java/org/junit/platform/commons/support/conversion/ConversionSupportTests.java

@@ -0,0 +1,338 @@
+package org.junit.platform.commons.support.conversion;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+
+import java.io.File;
+import java.lang.reflect.Method;
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.net.URI;
+import java.net.URL;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.time.Duration;
+import java.time.Instant;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.MonthDay;
+import java.time.OffsetDateTime;
+import java.time.OffsetTime;
+import java.time.Period;
+import java.time.Year;
+import java.time.YearMonth;
+import java.time.ZoneId;
+import java.time.ZoneOffset;
+import java.time.ZonedDateTime;
+import java.util.Currency;
+import java.util.Locale;
+import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+import org.junit.platform.commons.support.ReflectionSupport;
+import org.junit.platform.commons.test.TestClassLoader;
+import org.junit.platform.commons.util.ClassLoaderUtils;
+
+/**
+ * Unit tests for {@link ConversionSupport}.
+ *
+ * @since 5.12
+ */
+class ConversionSupportTests {
+
+	@Test
+	void isAwareOfNull() {
+		assertConverts(null, Object.class, null);
+		assertConverts(null, String.class, null);
+		assertConverts(null, Boolean.class, null);
+	}
+
+	@Test
+	void convertsStringsToPrimitiveTypes() {
+		assertConverts("true", boolean.class, true);
+		assertConverts("false", boolean.class, false);
+		assertConverts("o", char.class, 'o');
+		assertConverts("1", byte.class, (byte) 1);
+		assertConverts("1_0", byte.class, (byte) 10);
+		assertConverts("1", short.class, (short) 1);
+		assertConverts("1_2", short.class, (short) 12);
+		assertConverts("42", int.class, 42);
+		assertConverts("700_050_000", int.class, 700_050_000);
+		assertConverts("42", long.class, 42L);
+		assertConverts("4_2", long.class, 42L);
+		assertConverts("42.23", float.class, 42.23f);
+		assertConverts("42.2_3", float.class, 42.23f);
+		assertConverts("42.23", double.class, 42.23);
+		assertConverts("42.2_3", double.class, 42.23);
+	}
+
+	@Test
+	void convertsStringsToPrimitiveWrapperTypes() {
+		assertConverts("true", Boolean.class, true);
+		assertConverts("false", Boolean.class, false);
+		assertConverts("o", Character.class, 'o');
+		assertConverts("1", Byte.class, (byte) 1);
+		assertConverts("1_0", Byte.class, (byte) 10);
+		assertConverts("1", Short.class, (short) 1);
+		assertConverts("1_2", Short.class, (short) 12);
+		assertConverts("42", Integer.class, 42);
+		assertConverts("700_050_000", Integer.class, 700_050_000);
+		assertConverts("42", Long.class, 42L);
+		assertConverts("4_2", Long.class, 42L);
+		assertConverts("42.23", Float.class, 42.23f);
+		assertConverts("42.2_3", Float.class, 42.23f);
+		assertConverts("42.23", Double.class, 42.23);
+		assertConverts("42.2_3", Double.class, 42.23);
+	}
+
+	@ParameterizedTest(name = "[{index}] {0}")
+	@ValueSource(classes = { char.class, boolean.class, short.class, byte.class, int.class, long.class, float.class,
+			double.class, void.class })
+	void throwsExceptionForNullToPrimitiveTypeConversion(Class<?> type) {
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert(null, type)) //
+				.withMessage("Cannot convert null to primitive value of type " + type.getCanonicalName());
+	}
+
+	@ParameterizedTest(name = "[{index}] {0}")
+	@ValueSource(classes = { Boolean.class, Character.class, Short.class, Byte.class, Integer.class, Long.class,
+			Float.class, Double.class })
+	void throwsExceptionWhenConvertingTheWordNullToPrimitiveWrapperType(Class<?> type) {
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert("null", type)) //
+				.withMessage("Failed to convert String \"null\" to type " + type.getCanonicalName());
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert("NULL", type)) //
+				.withMessage("Failed to convert String \"NULL\" to type " + type.getCanonicalName());
+	}
+
+	@Test
+	void throwsExceptionOnInvalidStringForPrimitiveTypes() {
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert("ab", char.class)) //
+				.withMessage("Failed to convert String \"ab\" to type char") //
+				.havingCause() //
+				.withMessage("String must have length of 1: ab");
+
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert("tru", boolean.class)) //
+				.withMessage("Failed to convert String \"tru\" to type boolean") //
+				.havingCause() //
+				.withMessage("String must be 'true' or 'false' (ignoring case): tru");
+
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert("null", boolean.class)) //
+				.withMessage("Failed to convert String \"null\" to type boolean") //
+				.havingCause() //
+				.withMessage("String must be 'true' or 'false' (ignoring case): null");
+
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert("NULL", boolean.class)) //
+				.withMessage("Failed to convert String \"NULL\" to type boolean") //
+				.havingCause() //
+				.withMessage("String must be 'true' or 'false' (ignoring case): NULL");
+	}
+
+	@Test
+	void throwsExceptionWhenImplicitConversionIsUnsupported() {
+		assertThatExceptionOfType(ConversionException.class) //
+				.isThrownBy(() -> convert("foo", Enigma.class)) //
+				.withMessage("No built-in converter for source type java.lang.String and target type %s",
+						Enigma.class.getName());
+	}
+
+	/**
+	 * @since 5.4
+	 */
+	@Test
+	@SuppressWarnings("OctalInteger") // We test parsing octal integers here as well as hex.
+	void convertsEncodedStringsToIntegralTypes() {
+		assertConverts("0x1f", byte.class, (byte) 0x1F);
+		assertConverts("-0x1F", byte.class, (byte) -0x1F);
+		assertConverts("010", byte.class, (byte) 010);
+
+		assertConverts("0x1f00", short.class, (short) 0x1F00);
+		assertConverts("-0x1F00", short.class, (short) -0x1F00);
+		assertConverts("01000", short.class, (short) 01000);
+
+		assertConverts("0x1f000000", int.class, 0x1F000000);
+		assertConverts("-0x1F000000", int.class, -0x1F000000);
+		assertConverts("010000000", int.class, 010000000);
+
+		assertConverts("0x1f000000000", long.class, 0x1F000000000L);
+		assertConverts("-0x1F000000000", long.class, -0x1F000000000L);
+		assertConverts("0100000000000", long.class, 0100000000000L);
+	}
+
+	@Test
+	void convertsStringsToEnumConstants() {
+		assertConverts("DAYS", TimeUnit.class, TimeUnit.DAYS);
+	}
+
+	// --- java.io and java.nio ------------------------------------------------
+
+	@Test
+	void convertsStringToCharset() {
+		assertConverts("ISO-8859-1", Charset.class, StandardCharsets.ISO_8859_1);
+		assertConverts("UTF-8", Charset.class, StandardCharsets.UTF_8);
+	}
+
+	@Test
+	void convertsStringToFile() {
+		assertConverts("file", File.class, new File("file"));
+		assertConverts("/file", File.class, new File("/file"));
+		assertConverts("/some/file", File.class, new File("/some/file"));
+	}
+
+	@Test
+	void convertsStringToPath() {
+		assertConverts("path", Path.class, Paths.get("path"));
+		assertConverts("/path", Path.class, Paths.get("/path"));
+		assertConverts("/some/path", Path.class, Paths.get("/some/path"));
+	}
+
+	// --- java.lang -----------------------------------------------------------
+
+	@Test
+	void convertsStringToClass() {
+		assertConverts("java.lang.Integer", Class.class, Integer.class);
+		assertConverts("java.lang.Void", Class.class, Void.class);
+		assertConverts("java.lang.Thread$State", Class.class, Thread.State.class);
+		assertConverts("byte", Class.class, byte.class);
+		assertConverts("void", Class.class, void.class);
+		assertConverts("char[]", Class.class, char[].class);
+		assertConverts("java.lang.Long[][]", Class.class, Long[][].class);
+		assertConverts("[[[I", Class.class, int[][][].class);
+		assertConverts("[[Ljava.lang.String;", Class.class, String[][].class);
+	}
+
+	@Test
+	void convertsStringToClassWithCustomTypeFromDifferentClassLoader() throws Exception {
+		String customTypeName = Enigma.class.getName();
+		try (var testClassLoader = TestClassLoader.forClasses(Enigma.class)) {
+			var customType = testClassLoader.loadClass(customTypeName);
+			assertThat(customType.getClassLoader()).isSameAs(testClassLoader);
+
+			var declaringExecutable = ReflectionSupport.findMethod(customType, "foo").get();
+			assertThat(declaringExecutable.getDeclaringClass().getClassLoader()).isSameAs(testClassLoader);
+
+			var clazz = (Class<?>) convert(customTypeName, Class.class, classLoader(declaringExecutable));
+			assertThat(clazz).isNotEqualTo(Enigma.class);
+			assertThat(clazz).isEqualTo(customType);
+			assertThat(clazz.getClassLoader()).isSameAs(testClassLoader);
+		}
+	}
+
+	// --- java.math -----------------------------------------------------------
+
+	@Test
+	void convertsStringToBigDecimal() {
+		assertConverts("123.456e789", BigDecimal.class, new BigDecimal("123.456e789"));
+	}
+
+	@Test
+	void convertsStringToBigInteger() {
+		assertConverts("1234567890123456789", BigInteger.class, new BigInteger("1234567890123456789"));
+	}
+
+	// --- java.net ------------------------------------------------------------
+
+	@Test
+	void convertsStringToURI() {
+		assertConverts("https://docs.oracle.com/en/java/javase/12/", URI.class,
+				URI.create("https://docs.oracle.com/en/java/javase/12/"));
+	}
+
+	@Test
+	void convertsStringToURL() throws Exception {
+		assertConverts("https://junit.org/junit5", URL.class, URI.create("https://junit.org/junit5").toURL());
+	}
+
+	// --- java.time -----------------------------------------------------------
+
+	@Test
+	void convertsStringsToJavaTimeInstances() {
+		assertConverts("PT1234.5678S", Duration.class, Duration.ofSeconds(1234, 567800000));
+		assertConverts("1970-01-01T00:00:00Z", Instant.class, Instant.ofEpochMilli(0));
+		assertConverts("2017-03-14", LocalDate.class, LocalDate.of(2017, 3, 14));
+		assertConverts("2017-03-14T12:34:56.789", LocalDateTime.class,
+				LocalDateTime.of(2017, 3, 14, 12, 34, 56, 789_000_000));
+		assertConverts("12:34:56.789", LocalTime.class, LocalTime.of(12, 34, 56, 789_000_000));
+		assertConverts("--03-14", MonthDay.class, MonthDay.of(3, 14));
+		assertConverts("2017-03-14T12:34:56.789Z", OffsetDateTime.class,
+				OffsetDateTime.of(2017, 3, 14, 12, 34, 56, 789_000_000, ZoneOffset.UTC));
+		assertConverts("12:34:56.789Z", OffsetTime.class, OffsetTime.of(12, 34, 56, 789_000_000, ZoneOffset.UTC));
+		assertConverts("P2M6D", Period.class, Period.of(0, 2, 6));
+		assertConverts("2017", Year.class, Year.of(2017));
+		assertConverts("2017-03", YearMonth.class, YearMonth.of(2017, 3));
+		assertConverts("2017-03-14T12:34:56.789Z", ZonedDateTime.class,
+				ZonedDateTime.of(2017, 3, 14, 12, 34, 56, 789_000_000, ZoneOffset.UTC));
+		assertConverts("Europe/Berlin", ZoneId.class, ZoneId.of("Europe/Berlin"));
+		assertConverts("+02:30", ZoneOffset.class, ZoneOffset.ofHoursMinutes(2, 30));
+	}
+
+	// --- java.util -----------------------------------------------------------
+
+	@Test
+	void convertsStringToCurrency() {
+		assertConverts("JPY", Currency.class, Currency.getInstance("JPY"));
+	}
+
+	@Test
+	@SuppressWarnings("deprecation")
+	void convertsStringToLocale() {
+		assertConverts("en", Locale.class, Locale.ENGLISH);
+		assertConverts("en_us", Locale.class, new Locale(Locale.US.toString()));
+	}
+
+	@Test
+	void convertsStringToUUID() {
+		var uuid = "d043e930-7b3b-48e3-bdbe-5a3ccfb833db";
+		assertConverts(uuid, UUID.class, UUID.fromString(uuid));
+	}
+
+	// -------------------------------------------------------------------------
+
+	private void assertConverts(String input, Class<?> targetClass, Object expectedOutput) {
+		var result = convert(input, targetClass);
+
+		assertThat(result) //
+				.describedAs(input + " --(" + targetClass.getName() + ")--> " + expectedOutput) //
+				.isEqualTo(expectedOutput);
+	}
+
+	private Object convert(String input, Class<?> targetClass) {
+		return convert(input, targetClass, classLoader());
+	}
+
+	private Object convert(String input, Class<?> targetClass, ClassLoader classLoader) {
+		return ConversionSupport.convert(input, targetClass, classLoader);
+	}
+
+	private static ClassLoader classLoader() {
+		Method declaringExecutable = ReflectionSupport.findMethod(ConversionSupportTests.class, "foo").get();
+		return classLoader(declaringExecutable);
+	}
+
+	private static ClassLoader classLoader(Method declaringExecutable) {
+		return ClassLoaderUtils.getClassLoader(declaringExecutable.getDeclaringClass());
+	}
+
+	@SuppressWarnings("unused")
+	private static void foo() {
+	}
+
+	private static class Enigma {
+
+		@SuppressWarnings("unused")
+		void foo() {
+		}
+	}
+
+}