Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version forces users to use Eslint 9.7 #3787

Closed
ematipico opened this issue Jul 20, 2024 · 6 comments
Closed

Latest version forces users to use Eslint 9.7 #3787

ematipico opened this issue Jul 20, 2024 · 6 comments

Comments

@ematipico
Copy link

ematipico commented Jul 20, 2024

As the title says, the latest version forces users to bump eslint to 9.7.

However, the commit that changed it 4b3209b doesn't show any particular API that might have been introduced in v9.7.

I believe a generic v9 as peer dependency should be sufficient, so users aren't forced to 9.7, unless there's a reason visible in the changelog.

@ljharb
Copy link
Member

ljharb commented Jul 21, 2024

The reason is to reduce the support surface of the package. We never supported eslint 9 below 9.7, and there’s no reason to be using eslint 9 and not be using 9 latest, so why are you on an older version of v9?

@ematipico
Copy link
Author

I'm not sure I fully understand the meaning of the "support surface".

and there’s no reason to be using eslint 9 and not be using 9 latest

Should I expect this behaviour every time this library is bumped? Like, next time a minor is released, will you bump the V9 peer dep to the latest?

so why are you on an older version of v9?

Maintenance creep, mostly. However, I was mostly concerned about the logic of the peer dependency, because all the other versions of Eslint (V8, v7, etc) don't depend on the latest.

@etherealm13
Copy link

yarn test fails after the latest bump due to missing eslint.config file.

ESLint: 9.7.0
ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

@ljharb
Copy link
Member

ljharb commented Jul 21, 2024

@ematipico

Should I expect this behaviour every time this library is bumped? Like, next time a minor is released, will you bump the V9 peer dep to the latest?

no, of course not. That would be a breaking change.

@ljharb
Copy link
Member

ljharb commented Jul 21, 2024

@etherealm13 if you’re upgrading to eslint 9, flat config is the default, so you either need to use the env var to select eslintrc, or migrate your config. That’s an eslint question tho, not related to this plugin.

@voxpelli
Copy link
Contributor

Version 7.34.4 had this:

  "peerDependencies": {
    "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8"
  },

Version 7.35.0 had this:

  "peerDependencies": {
    "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7"
  },

The latter is a strict superset of the former. 9.x was not supported in 7.34.4.

(I think this issue can be closed)

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants