Skip to content

Commit 9058c86

Browse files
Brian Grangerfperez
Brian Granger
authored andcommitted
Add Brian's comments regarding an elusive non-fatal error in the trial tests.
1 parent 3c479bb commit 9058c86

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

IPython/kernel/tests/engineservicetest.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -359,12 +359,15 @@ def testDelHasProperties(self):
359359
return d
360360

361361
def testStrictDict(self):
362-
s = """from IPython.kernel.engineservice import get_engine
363-
p = get_engine(%s).properties"""%self.engine.id
362+
s = """from IPython.kernel.engineservice import get_engine; p = get_engine(%s).properties"""%self.engine.id
364363
d = self.engine.execute(s)
364+
# These 3 lines cause a weird testing error on some platforms (OS X).
365+
# I am leaving them here in case they are masking some really
366+
# weird reactor issue. For now I will just keep my eye on this.
365367
d.addCallback(lambda r: self.engine.execute("p['a'] = lambda _:None"))
366368
d.addErrback(lambda f: self.assertRaises(error.InvalidProperty,
367369
f.raiseException))
370+
# Below here seems to be fine
368371
d.addCallback(lambda r: self.engine.execute("p['a'] = range(5)"))
369372
d.addCallback(lambda r: self.engine.execute("p['a'].append(5)"))
370373
d.addCallback(lambda r: self.engine.get_properties('a'))

0 commit comments

Comments
 (0)