chore: add linting

Closes ng-bootstrap#184

Author: Foxandxss

gulpfile.js

@@ -10,6 +10,7 @@ var merge = require('merge2');
 var clangFormat = require('clang-format');
 var gulpFormat = require('gulp-clang-format');
 var runSequence = require('run-sequence');
+var tslint = require('gulp-tslint');
 var webpack = require('webpack');
 var webpackDemoConfig = require('./webpack.demo.js');
 
@@ -101,6 +102,12 @@ gulp.task('tdd', ['clean:build-tests'], function(done) {
 
 // Formatting
 
+gulp.task('lint', function() {
+  return gulp.src(PATHS.src).pipe(tslint({configuration: require('./tslint.json')})).pipe(tslint.report('prose', {
+    summarizeFailureOutput: true
+  }));
+});
+
 gulp.task('check-format', function() {
   return doCheckFormat().on(
       'warning', function(e) { console.log("NOTE: this will be promoted to an ERROR in the continuous build"); });
@@ -135,11 +142,11 @@ gulp.task('demo-push', function() { return gulp.src(PATHS.demoDist).pipe(ghPages
 gulp.task('clean', ['clean:build', 'clean:tests', 'clean:demo', 'clean:demo-cache']);
 
 gulp.task('build', function(done) {
-  runSequence('enforce-format', 'ddescribe-iit', 'test', 'clean:build', 'cjs', 'umd', done);
+  runSequence('lint', 'enforce-format', 'ddescribe-iit', 'test', 'clean:build', 'cjs', 'umd', done);
 });
 
 gulp.task('deploy-demo', function(done) {
   runSequence('clean:demo', 'copy:polyfills-demo', 'build:demo', 'demo-push', 'clean:demo-cache', done);
 });
 
-gulp.task('default', function(done) { runSequence('enforce-format', 'ddescribe-iit', 'test', done); });
+gulp.task('default', function(done) { runSequence('lint', 'enforce-format', 'ddescribe-iit', 'test', done); });

package.json

@@ -41,6 +41,7 @@
     "gulp-gh-pages": "^0.5.4",
     "gulp-shell": "^0.5.1",
     "gulp-sourcemaps": "^1.6.0",
+    "gulp-tslint": "^5.0.0",
     "gulp-typescript": "^2.9.2",
     "gulp-util": "^3.0.6",
     "html-loader": "^0.4.3",
@@ -66,6 +67,7 @@
     "style-loader": "^0.13.1",
     "systemjs": "^0.19.26",
     "ts-loader": "^0.8.2",
+    "tslint": "^3.8.1",
     "typescript": "^1.6.2",
     "typings": "^0.7.9",
     "url-loader": "^0.5.7",

src/accordion/accordion.ts

@@ -11,7 +11,7 @@ import {
 
 import {NgbCollapse} from '../collapse/collapse';
 
-var nextId = 0;
+let nextId = 0;
 
 @Component({
   selector: 'ngb-panel',
@@ -71,7 +71,7 @@ export class NgbAccordion implements AfterContentChecked {
   }
 
   ngAfterContentChecked() {
-    var openPanels = this._panels.toArray().filter((panel) => panel.open);
+    const openPanels = this._panels.toArray().filter((panel) => panel.open);
     if (openPanels.length > 1) {
       this.closeOthers(openPanels[0]);
     }

src/collapse/collapse.spec.ts

@@ -20,7 +20,7 @@ function getCollapsibleContent(element: HTMLElement): HTMLDivElement {
 
 describe('ngb-collapse', () => {
 
-  const html = `<div [ngbCollapse]="collapsed">Some content</div>`;
+  let html = `<div [ngbCollapse]="collapsed">Some content</div>`;
 
   it('should have content open and aria-expanded true', async(inject([TestComponentBuilder], (tcb) => {
        tcb.overrideTemplate(TestComponent, html).createAsync(TestComponent).then((fixture) => {
@@ -65,7 +65,7 @@ describe('ngb-collapse', () => {
      })));
 
   it('should allow toggling collapse from outside', async(inject([TestComponentBuilder], (tcb) => {
-       const html = `
+       html = `
       <button (click)="collapse.collapsed = !collapse.collapsed">Collapse</button>
       <div [ngbCollapse] #collapse="ngbCollapse"></div>`;
 

src/modal/modal_backdrop.ts

@@ -1,5 +1,5 @@
-import {Component} from "@angular/core";
+import {Component} from '@angular/core';
 
-@Component({selector: 'ngb-modal-backdrop', template: '', host: {"class": "modal-backdrop"}})
+@Component({selector: 'ngb-modal-backdrop', template: '', host: {'class': 'modal-backdrop'}})
 export class NgbModalBackdrop {
 }

src/modal/modal_window.spec.ts

@@ -12,7 +12,7 @@ import {
 import {TestComponentBuilder} from '@angular/compiler/testing';
 
 import {NgbModalWindow} from './modal_window';
-import {ModalDismissReasons} from "./modal_dismiss_reasons";
+import {ModalDismissReasons} from './modal_dismiss_reasons';
 
 describe('ngb-modal-dialog', () => {
 
@@ -22,8 +22,8 @@ describe('ngb-modal-dialog', () => {
          tcb.createAsync(NgbModalWindow).then((fixture) => {
            fixture.detectChanges();
 
-           var modalEl: Element = fixture.nativeElement;
-           var dialogEl: Element = fixture.nativeElement.querySelector('.modal-dialog');
+           const modalEl: Element = fixture.nativeElement;
+           const dialogEl: Element = fixture.nativeElement.querySelector('.modal-dialog');
 
            expect(modalEl).toHaveCssClass('modal');
            expect(dialogEl).toHaveCssClass('modal-dialog');
@@ -36,7 +36,7 @@ describe('ngb-modal-dialog', () => {
            fixture.componentInstance.size = 'sm';
            fixture.detectChanges();
 
-           var dialogEl: Element = fixture.nativeElement.querySelector('.modal-dialog');
+           const dialogEl: Element = fixture.nativeElement.querySelector('.modal-dialog');
            expect(dialogEl).toHaveCssClass('modal-dialog');
            expect(dialogEl).toHaveCssClass('modal-sm');
          });
@@ -45,7 +45,7 @@ describe('ngb-modal-dialog', () => {
 
   describe('dismiss', () => {
 
-    var tcb: TestComponentBuilder;
+    let tcb: TestComponentBuilder;
 
     beforeEach(inject([TestComponentBuilder], (tcBuilder) => { tcb = tcBuilder; }));
 

src/modal/modal_window.ts

@@ -4,17 +4,17 @@ import {
   EventEmitter,
   Input,
   HostListener,
-} from "@angular/core";
+} from '@angular/core';
 
 import {ModalDismissReasons} from './modal_dismiss_reasons';
 
 @Component({
   selector: 'ngb-modal-window',
-  host: {"class": "modal", "role": "dialog", "tabindex": "-1", "style": "display: block;"},
+  host: {'class': 'modal', 'role': 'dialog', 'tabindex': '-1', 'style': 'display: block;'},
   template: `
         <div [class]="'modal-dialog' + (size ? ' modal-' + size : '')">
             <div class="modal-content" (click)="stopPropagation($event)">
-                <ng-content></ng-content>                          
+                <ng-content></ng-content>
             </div>
         </div>
     `

src/pager/pager.spec.ts

@@ -17,7 +17,7 @@ import {Component} from '@angular/core';
 import {NgbPager} from './pager';
 
 function expectPager(nativeEl: HTMLElement, pagerStates: boolean[]): void {
-  var pagerCtrls = nativeEl.querySelectorAll('li');
+  const pagerCtrls = nativeEl.querySelectorAll('li');
 
   if (pagerStates[0]) {
     expect(pagerCtrls[0]).not.toHaveCssClass('disabled');
@@ -40,7 +40,7 @@ describe('ngb-pagination', () => {
 
   describe('business logic', () => {
 
-    var pager: NgbPager;
+    let pager: NgbPager;
 
     beforeEach(() => { pager = new NgbPager(); });
 

src/pager/pager.ts

@@ -20,19 +20,19 @@ export class NgbPager implements OnChanges {
 
   prev(): void {
     if (this.hasPrev()) {
-      this.pageChange.emit(--this._currentPage)
+      this.pageChange.emit(--this._currentPage);
     }
   }
 
   next(): void {
     if (this.hasNext()) {
-      this.pageChange.emit(++this._currentPage)
+      this.pageChange.emit(++this._currentPage);
     }
   }
 
   hasPrev(): boolean { return this._currentPage > 0; }
 
   hasNext(): boolean { return this._currentPage < this.noOfPages - 1; }
 
-  ngOnChanges(): void { this._currentPage = Math.max(Math.min(this.page, this.noOfPages - 1), 0) }
+  ngOnChanges(): void { this._currentPage = Math.max(Math.min(this.page, this.noOfPages - 1), 0); }
 }

src/pagination/pagination.spec.ts

@@ -17,7 +17,7 @@ import {Component} from '@angular/core';
 import {NgbPagination} from './pagination';
 
 function expectPages(nativeEl: HTMLElement, pagesDef: string[]): void {
-  var pages = nativeEl.querySelectorAll('li');
+  const pages = nativeEl.querySelectorAll('li');
 
   expect(pages.length).toEqual(pagesDef.length);
 
@@ -53,7 +53,7 @@ describe('ngb-pagination', () => {
 
   describe('business logic', () => {
 
-    var pagination: NgbPagination;
+    let pagination: NgbPagination;
 
     beforeEach(() => { pagination = new NgbPagination(); });
 

src/pagination/pagination.ts

@@ -62,21 +62,21 @@ export class NgbPagination implements OnChanges {
   hasNext(): boolean { return this.page < this.pages.length; }
 
   selectPage(pageNumber: number): void {
-    var prevPageNo = this.page;
+    let prevPageNo = this.page;
     this._page = this._getPageNoInRange(pageNumber);
 
-    if (this.page != prevPageNo) {
+    if (this.page !== prevPageNo) {
       this.pageChange.emit(this.page);
     }
   }
 
   ngOnChanges(): void {
     // re-calculate new length of pages
-    var pageCount = Math.ceil(this._collectionSize / this._pageSize);
+    let pageCount = Math.ceil(this._collectionSize / this._pageSize);
 
     // fill-in model needed to render pages
     this.pages.length = 0;
-    for (var i = 1; i <= pageCount; i++) {
+    for (let i = 1; i <= pageCount; i++) {
       this.pages.push(i);
     }
 

src/radio/radio.spec.ts

@@ -5,7 +5,7 @@ import {NGB_RADIO_DIRECTIVES} from './radio';
 
 
 function expectRadios(element: HTMLElement, states: number[]) {
-  var labels = element.querySelectorAll('label');
+  const labels = element.querySelectorAll('label');
   expect(labels.length).toEqual(states.length);
 
   for (let i = 0; i < states.length; i++) {

src/radio/radio.ts

@@ -46,7 +46,7 @@ export class NgbRadioGroup implements ControlValueAccessor {
 
   private _setGroupValue(radio: NgbRadio) {
     this._selectedRadio = radio;
-    var value = radio ? radio.value : null;
+    const value = radio ? radio.value : null;
     this.writeValue(value);
     this.onChange(value);
   }
@@ -77,7 +77,7 @@ export class NgbRadio implements OnDestroy {
   @Input('value')
   set value(value) {
     this._value = value;
-    var stringValue = value ? value.toString() : '';
+    const stringValue = value ? value.toString() : '';
     this.renderer.setElementProperty(this.element.nativeElement, 'value', stringValue);
 
     if (this.group) {

src/rating/rating.ts

@@ -6,7 +6,8 @@ import {Component, Input, Output, EventEmitter, OnInit} from '@angular/core';
     <span tabindex="0" (mouseleave)="reset()" aria-valuemin="0" [attr.aria-valuemax]="max" [attr.aria-valuenow]="rate">
       <template ngFor let-r [ngForOf]="range" let-index="index">
         <span class="sr-only">({{ index < rate ? '*' : ' ' }})</span>
-        <i class="glyphicon {{index < rate ? 'glyphicon-star' : 'glyphicon-star-empty'}}" (mouseenter)="enter(index + 1)" (click)="update(index + 1)" [title]="r.title" [attr.aria-valuetext]="r.title"></i>
+        <i class="glyphicon {{index < rate ? 'glyphicon-star' : 'glyphicon-star-empty'}}" (mouseenter)="enter(index + 1)"
+          (click)="update(index + 1)" [title]="r.title" [attr.aria-valuetext]="r.title"></i>
       </template>
     </span>
   `

src/tabset/tabset.spec.ts

@@ -25,13 +25,13 @@ function getTabContent(nativeEl: HTMLElement) {
 }
 
 function expectActiveTabs(nativeEl: HTMLElement, active: boolean[]) {
-  var tabTitles = getTabTitles(nativeEl);
-  var tabContent = getTabContent(nativeEl);
+  const tabTitles = getTabTitles(nativeEl);
+  const tabContent = getTabContent(nativeEl);
 
   expect(tabTitles.length).toBe(active.length);
   expect(tabContent.length).toBe(active.length);
 
-  for (var i = 0; i < active.length; i++) {
+  for (let i = 0; i < active.length; i++) {
     if (active[i]) {
       expect(tabTitles[i]).toHaveCssClass('active');
       expect(tabContent[i]).toHaveCssClass('active');
@@ -55,8 +55,8 @@ describe('ngb-tabset', () => {
        tcb.overrideTemplate(TestComponent, html).createAsync(TestComponent).then((fixture) => {
          fixture.detectChanges();
 
-         var tabTitles = getTabTitles(fixture.nativeElement);
-         var tabContent = getTabContent(fixture.nativeElement);
+         const tabTitles = getTabTitles(fixture.nativeElement);
+         const tabContent = getTabContent(fixture.nativeElement);
 
          expect(tabTitles[0].textContent).toMatchPattern(/foo/);
          expect(tabTitles[1].textContent).toMatchPattern(/bar/);
@@ -85,7 +85,7 @@ describe('ngb-tabset', () => {
        tcb.overrideTemplate(TestComponent, html).createAsync(TestComponent).then((fixture) => {
          fixture.detectChanges();
 
-         var tabTitles = getTabTitles(fixture.nativeElement);
+         const tabTitles = getTabTitles(fixture.nativeElement);
 
          expect(tabTitles[0].textContent).toMatchPattern(/foo/);
          expect(tabTitles[1].innerHTML).toMatchPattern(/<b>bar<\/b>/);
@@ -137,7 +137,7 @@ describe('ngb-tabset', () => {
        tcb.overrideTemplate(TestComponent, html).createAsync(TestComponent).then((fixture) => {
          fixture.detectChanges();
 
-         var tabTitles = getTabTitles(fixture.nativeElement);
+         const tabTitles = getTabTitles(fixture.nativeElement);
 
          (<HTMLAnchorElement>tabTitles[1]).click();
          fixture.detectChanges();

src/util/triggers.spec.ts

@@ -17,23 +17,23 @@ describe('triggers', () => {
   describe('parseTriggers', () => {
 
     it('should parse single trigger', () => {
-      var t = parseTriggers('foo');
+      const t = parseTriggers('foo');
 
       expect(t.length).toBe(1);
       expect(t[0].open).toBe('foo');
       expect(t[0].close).toBe('foo');
     });
 
     it('should parse open:close form', () => {
-      var t = parseTriggers('foo:bar');
+      const t = parseTriggers('foo:bar');
 
       expect(t.length).toBe(1);
       expect(t[0].open).toBe('foo');
       expect(t[0].close).toBe('bar');
     });
 
     it('should parse multiple triggers', () => {
-      var t = parseTriggers('foo:bar bar:baz');
+      const t = parseTriggers('foo:bar bar:baz');
 
       expect(t.length).toBe(2);
       expect(t[0].open).toBe('foo');
@@ -43,7 +43,7 @@ describe('triggers', () => {
     });
 
     it('should parse multiple triggers with mixed forms', () => {
-      var t = parseTriggers('foo bar:baz');
+      const t = parseTriggers('foo bar:baz');
 
       expect(t.length).toBe(2);
       expect(t[0].open).toBe('foo');
@@ -53,7 +53,7 @@ describe('triggers', () => {
     });
 
     it('should properly trim excessive white-spaces', () => {
-      var t = parseTriggers('foo   bar  \n baz ');
+      const t = parseTriggers('foo   bar  \n baz ');
 
       expect(t.length).toBe(3);
       expect(t[0].open).toBe('foo');
@@ -65,17 +65,17 @@ describe('triggers', () => {
     });
 
     it('should lookup and translate special aliases', () => {
-      var t = parseTriggers('hover');
+      const t = parseTriggers('hover');
 
       expect(t.length).toBe(1);
       expect(t[0].open).toBe('mouseenter');
       expect(t[0].close).toBe('mouseleave');
     });
 
     it('should detect manual triggers', () => {
-      var t = parseTriggers('manual');
+      const t = parseTriggers('manual');
 
-      expect(t[0].isManual).toBeTruthy()
+      expect(t[0].isManual).toBeTruthy();
     });
 
     it('should ignore empty inputs', () => {