From e17d83f44d7d1845a913d48900fc4dea4608ac51 Mon Sep 17 00:00:00 2001 From: Timmy Willison Date: Tue, 18 Feb 2025 09:53:08 -0500 Subject: [PATCH] fix(selenium): fix verbose mode with await - the types didn't update between driver var assignments - added -v to the jquery tests to the path is hit --- .github/workflows/jquery.yml | 2 +- selenium/createDriver.js | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/jquery.yml b/.github/workflows/jquery.yml index a515649..2e8c7c5 100644 --- a/.github/workflows/jquery.yml +++ b/.github/workflows/jquery.yml @@ -37,4 +37,4 @@ jobs: - name: Run jQuery tests working-directory: test/jquery - run: npm install && npm run test:browser + run: npm install && npm run test:browser -- -v diff --git a/selenium/createDriver.js b/selenium/createDriver.js index fd90ad8..40f8a86 100644 --- a/selenium/createDriver.js +++ b/selenium/createDriver.js @@ -21,8 +21,6 @@ export default async function createDriver( { browserName, headless, url, verbos capabilities.setLoggingPrefs( prefs ); } - let driver = new Builder().withCapabilities( capabilities ); - const chromeOptions = new Chrome.Options(); chromeOptions.addArguments( "--enable-chrome-browser-cloud-management" ); @@ -73,7 +71,7 @@ export default async function createDriver( { browserName, headless, url, verbos } } - driver = await driver + const driver = new Builder().withCapabilities( capabilities ) .setChromeOptions( chromeOptions ) .setFirefoxOptions( firefoxOptions ) .setEdgeOptions( edgeOptions ) @@ -81,7 +79,7 @@ export default async function createDriver( { browserName, headless, url, verbos .build(); if ( verbose ) { - const driverCapabilities = driver.getCapabilities(); + const driverCapabilities = await driver.getCapabilities(); const name = driverCapabilities.getBrowserName(); const version = driverCapabilities.getBrowserVersion(); console.log( `\nDriver created for ${ name } ${ version }` );