Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature✨: Support promise step-handling out of the box #6

Open
josias-r opened this issue Nov 7, 2022 · 0 comments
Open

Feature✨: Support promise step-handling out of the box #6

josias-r opened this issue Nov 7, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@josias-r
Copy link
Owner

josias-r commented Nov 7, 2022

The preventMove + continue API can already be used to easily write async step-handling.

This could be simplified by supporting promises out of the box.

So this:

onNext: async () => {
   boarding.preventMove();
   await myPromise();
   boarding.continue();
},

Could become this:

onNext: async () => {
   await myPromise();
},

Where continue & preventMove are auto handled by the library in the background in case a promise is returned from the handler.

@josias-r josias-r added the enhancement New feature or request label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant