Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with "Automatic Backlinks to note" plugin #30

Open
S73ph4n opened this issue Jan 6, 2022 · 4 comments
Open

Conflicts with "Automatic Backlinks to note" plugin #30

S73ph4n opened this issue Jan 6, 2022 · 4 comments

Comments

@S73ph4n
Copy link

S73ph4n commented Jan 6, 2022

Hello,
Good job on this plugin, it is extremely useful !

Just a minor inconvenience :
I've just noticed that it does not seem to work if the "Automatic Backlinks to note" plugin is also installed (even if it isn't set up to display the backlinks). I can insert references but they just don't appear at the end of the note.

Without Backlinks plugin :
image

With Backlinks plugin :
image

  • Joplin V2.6.10
  • BibTex plugin V0.5.0
  • Automatic backlinks to note V3.0.3
@white-c
Copy link

white-c commented Mar 14, 2022

I am having the same issue. I have tried changing all of the options but it doesn't fix the issue.

Joplin 2.7.14
BibTex 0.5.0
Automatic Backlinks to note 3.0.3

@nunesgh
Copy link

nunesgh commented Jun 27, 2022

Same issue here.

Joplin 2.8.8
BibTex 0.5.0
Automatic Backlinks to note 3.0.3

@sepremento
Copy link

To fix this problem you will need to change two lines in both plugins:
https://github.com/ambrt/joplin-plugin-referencing-notes/blob/master/src/notesReferences.js#L23
https://github.com/joplin/plugin-bibtex/blob/main/src/ui/bibliography-renderer/render-list-content-script.ts#L73

and instead of <style onload="..."/> make a properly closed HTML tag <style onload="..."></style>.

The problem seems to stem from <style> tag not being closed and then it is somehow rendered as <style onload="..."></div></style> and when another plugin tries to render its content it is rendered inside the first <style> tag and so is not visible.

I will try to refactor @ambrt plugin and push some changes in my spare time, but he has not been around for a while. And maybe @xUser5000 will notice this post here.

@funkeyfreak
Copy link

funkeyfreak commented Apr 22, 2023

I've replicated @sepremento's fix and created the PRs in their respective repositories:

Let me know if I've missed anything @sepremento

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants