Submitting time logs (spent time) to gitlab since 11.1.0 is broken

[ChrisSchaetzle]

Your Environment

• Version used: 11.1.0 (debug) and 11.1.2 (flatpak), master
• Operating System and version: Fedora 41
• Desktop Environment: KDE
• Browser Name and version: Chrome, Edge, RPM, Flatpak

Expected Behavior

When I click on the "Finish Day" button a dialog should pop up asking me if I want to submit my spent time to GitLab.

Current Behavior

When I click on the "Finish Day" button the above mentioned dialog does not appear.

Steps to Reproduce (for bugs)

1. Setup a GitLab project
2. Book time to the project
3. finish day

Can you reproduce this reliably?

Always on versions 11.10 and newer

Log: As far as I can tell it is not very use full

[2025-01-11 15:22:10.546] [info] close, isQuiting: undefined
[2025-01-11 15:22:10.550] [info] Actions to wait for [ 'FINISH_DAY_BEFORE_CLOSE_EFFECT' ]
[2025-01-11 15:22:10.553] [info] BEFORE_CLOSE_DONE FINISH_DAY_BEFORE_CLOSE_EFFECT []
[2025-01-11 15:22:10.553] [info] close, isQuiting: undefined
[2025-01-11 15:22:10.554] [info] close, isQuiting: true
[2025-01-11 15:22:10.566] [info] Quit after all windows being closed
[2025-01-11 15:22:12.901] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:22:12.978] [info] Saving backups to /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/backups
[2025-01-11 15:22:13.393] [info] No custom styles detected at /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/styles.css
[2025-01-11 15:22:16.419] [info] close, isQuiting: undefined
[2025-01-11 15:22:16.424] [info] Actions to wait for [ 'FINISH_DAY_BEFORE_CLOSE_EFFECT' ]
[2025-01-11 15:22:16.428] [info] BEFORE_CLOSE_DONE FINISH_DAY_BEFORE_CLOSE_EFFECT []
[2025-01-11 15:22:16.429] [info] close, isQuiting: undefined
[2025-01-11 15:22:16.431] [info] close, isQuiting: true
[2025-01-11 15:22:16.441] [info] Quit after all windows being closed
[2025-01-11 15:22:24.150] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:22:36.050] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:22:36.127] [info] Saving backups to /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/backups
[2025-01-11 15:22:36.549] [info] No custom styles detected at /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/styles.css
[2025-01-11 15:33:28.762] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:33:43.590] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:33:43.659] [info] Saving backups to /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/backups
[2025-01-11 15:33:44.078] [info] No custom styles detected at /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/styles.css
[2025-01-11 15:37:10.402] [info] close, isQuiting: undefined
[2025-01-11 15:37:10.406] [info] Actions to wait for [ 'FINISH_DAY_BEFORE_CLOSE_EFFECT' ]
[2025-01-11 15:37:10.409] [info] BEFORE_CLOSE_DONE FINISH_DAY_BEFORE_CLOSE_EFFECT []
[2025-01-11 15:37:10.409] [info] close, isQuiting: undefined
[2025-01-11 15:37:10.411] [info] close, isQuiting: true
[2025-01-11 15:37:10.465] [info] Quit after all windows being closed
[2025-01-11 15:40:16.965] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:42:09.135] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:46:51.231] [info] { enabled: null, showDevTools: false, mode: 'bottom' }
[2025-01-11 15:46:51.327] [info] Saving backups to /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/backups
[2025-01-11 15:46:51.750] [info] No custom styles detected at /home/user/.var/app/com.super_productivity.SuperProductivity/config/superProductivity/styles.css
[2025-01-11 15:49:18.718] [info] close, isQuiting: undefined

[github-actions]

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

[github-actions]

Hello there ChrisSchaetzle! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

[johannesjo]

Help with this would be very welcome!

This is roughly related, since it also affects the GitLab integration:
#3901

[Blackclaws]

Very likely still the same issue: #3447

[Greexter]

It looks like the dialog isn't even packaged with the application, so I assume it was trimmed due to not being really used. From looking at the code, I indeed couldn't find the dialog being opened from anywhere.

It seems to me that the issue was introduced in the following commit: d524b8f#diff-f6deb54e22b334f31e4f46c15d7da12badc57ba085ce01a24f505d4dc58d5ec8

The gitlab-issue.module.ts file was deleted, but it contained the registration for opening the GitLab worklog dialog.

If I take a look at how the Jira provider handles things, it looks like it uses effects to show the dialog. The analogous class for GitLab (gitlab-issue.effects.ts), however, does not contain this function.

I'm not familiar with Angular, so I may be mistaken, but I think the registration for opening of the dialog just got accidentally deleted during the refactor.

[johannesjo]

@Greexter I appreciate it, if you take a look. However, not registering the Dialog should not be the issue (there would be an error, if there was an attempt to open it).

[Greexter]

@johannesjo What I meant is that the code opening the dialog on finish day is missing, not that the dialog itself is not registered. So no error will occur since nothing will try to open it.

Moving the code from the constructor of the deleted file to the constructor of gitlab-issue.effects.ts seems to fix this. However, I am not sure if it is the right place for it.

[johannesjo]

Ah alright :)

I think it is fine to put it there for now. Maybe we find a better place later on. Could you provide a PR for the fix you made?

[ChrisSchaetzle]

The above fix also works for me. Thank you very much.
I'm sorry I couldn't be of more help with this.

Closing - issue is fixed on master