feat(lint) update linter and apply it to TS code

Author: saghul

.eslintignore

@@ -11,3 +11,7 @@ doc/example/libs/*
 # not seem to be a reason why we will want to risk being inconsistent with our
 # remaining JavaScript source code.
 !.eslintrc.js
+
+*.d.ts
+*.spec.ts
+*.spec.js

.eslintrc.js

@@ -4,5 +4,18 @@ module.exports = {
     },
     'extends': [
         '@jitsi/eslint-config'
+    ],
+    'overrides': [
+        {
+            'files': [ '*.ts' ],
+            extends: [ '@jitsi/eslint-config/typescript' ],
+            parserOptions: {
+                sourceType: 'module',
+                project: [ 'tsconfig.json' ]
+            },
+            rules: {
+                'no-continue': 0
+            }
+        }
     ]
 };

JitsiConferenceErrors.ts

@@ -3,6 +3,7 @@
  */
 
 export enum JitsiConferenceErrors {
+
     /**
      * Indicates that client must be authenticated to create the conference.
      */
@@ -14,9 +15,10 @@ export enum JitsiConferenceErrors {
     CHAT_ERROR = 'conference.chatError',
 
     /**
-     * Indicates that a settings error occurred.
+     * Indicates that a connection error is due to denied access to the room,
+     * occurred after joining a lobby room and access is denied by the room moderators.
      */
-    SETTINGS_ERROR = 'conference.settingsError',
+    CONFERENCE_ACCESS_DENIED = 'conference.connectionError.accessDenied',
 
     /**
      * Indicates that conference has been destroyed.
@@ -28,34 +30,16 @@ export enum JitsiConferenceErrors {
      */
     CONFERENCE_MAX_USERS = 'conference.max_users',
 
-    /**
-     * Indicates that a connection error occurred when trying to join a conference.
-     */
-    CONNECTION_ERROR = 'conference.connectionError',
-
     /**
      * Indicates that the client has been forced to restart by jicofo when the
      * conference was migrated from one bridge to another.
      */
     CONFERENCE_RESTARTED = 'conference.restarted',
 
     /**
-     * Indicates that a connection error is due to not allowed,
-     * occurred when trying to join a conference.
-     */
-    NOT_ALLOWED_ERROR = 'conference.connectionError.notAllowed',
-
-    /**
-     * Indicates that a connection error is due to not allowed,
-     * occurred when trying to join a conference, only approved members are allowed to join.
-     */
-    MEMBERS_ONLY_ERROR = 'conference.connectionError.membersOnly',
-
-    /**
-     * Indicates that a connection error is due to denied access to the room,
-     * occurred after joining a lobby room and access is denied by the room moderators.
+     * Indicates that a connection error occurred when trying to join a conference.
      */
-    CONFERENCE_ACCESS_DENIED = 'conference.connectionError.accessDenied',
+    CONNECTION_ERROR = 'conference.connectionError',
 
     /**
      * Indicates that the display name is required when joining the room.
@@ -90,6 +74,18 @@ export enum JitsiConferenceErrors {
      */
     INCOMPATIBLE_SERVER_VERSIONS = 'conference.incompatible_server_versions',
 
+    /**
+     * Indicates that a connection error is due to not allowed,
+     * occurred when trying to join a conference, only approved members are allowed to join.
+     */
+    MEMBERS_ONLY_ERROR = 'conference.connectionError.membersOnly',
+
+    /**
+     * Indicates that a connection error is due to not allowed,
+     * occurred when trying to join a conference.
+     */
+    NOT_ALLOWED_ERROR = 'conference.connectionError.notAllowed',
+
     /**
      * Indicates that offer/answer had failed.
      */
@@ -110,6 +106,11 @@ export enum JitsiConferenceErrors {
      */
     RESERVATION_ERROR = 'conference.reservationError',
 
+    /**
+     * Indicates that a settings error occurred.
+     */
+    SETTINGS_ERROR = 'conference.settingsError',
+
     /**
      * Indicates that there is no available videobridge.
      */

JitsiConferenceEvents.ts

@@ -2,19 +2,6 @@
  * The events for the conference.
  */
 export enum JitsiConferenceEvents {
-    /**
-     * An event(library-private) fired when the conference switches the currently active media session.
-     * @type {string}
-     * @private
-     */
-    _MEDIA_SESSION_ACTIVE_CHANGED = 'conference.media_session.active_changed',
-
-    /**
-     * An event(library-private) fired when a new media session is added to the conference.
-     * @type {string}
-     * @private
-     */
-    _MEDIA_SESSION_STARTED = 'conference.media_session.started',
 
     /**
      * Event indicates that the current conference audio input switched between audio
@@ -23,8 +10,8 @@ export enum JitsiConferenceEvents {
     AUDIO_INPUT_STATE_CHANGE = 'conference.audio_input_state_changed',
 
     /**
-     * Event indicates that the permission for unmuting audio has changed based on the number of audio senders in the call
-     * and the audio sender limit configured in Jicofo.
+     * Event indicates that the permission for unmuting audio has changed based on the number of audio senders in the
+     * call and the audio sender limit configured in Jicofo.
      */
     AUDIO_UNMUTE_PERMISSIONS_CHANGED = 'conference.audio_unmute_permissions_changed',
 
@@ -115,17 +102,17 @@ export enum JitsiConferenceEvents {
      */
     CONFERENCE_FAILED = 'conference.failed',
 
-    /**
-     * Indicates that conference is in progress of joining.
-     */
-    CONFERENCE_JOIN_IN_PROGRESS = 'conference.join_in_progress',
-
     /**
      * Indicates that conference has been joined. The event does NOT provide any
      * parameters to its listeners.
      */
     CONFERENCE_JOINED = 'conference.joined',
 
+    /**
+     * Indicates that conference is in progress of joining.
+     */
+    CONFERENCE_JOIN_IN_PROGRESS = 'conference.join_in_progress',
+
     /**
      * Indicates that conference has been left.
      */
@@ -163,7 +150,7 @@ export enum JitsiConferenceEvents {
 
     /**
      * A connection to the video bridge's data channel has been closed.
-     * This event is only emitted in 
+     * This event is only emitted in
      */
     DATA_CHANNEL_CLOSED = 'conference.dataChannelClosed',
 
@@ -284,21 +271,11 @@ export enum JitsiConferenceEvents {
      */
     MESSAGE_RECEIVED = 'conference.messageReceived',
 
-    /**
-     * New reaction was received.
-     */
-    REACTION_RECEIVED = 'conference.reactionReceived',
-
     /**
      * Event fired when the conference metadata is updated.
      */
     METADATA_UPDATED = 'conference.metadata.updated',
 
-    /**
-     * Event indicates that the current selected input device has no signal
-     */
-    NO_AUDIO_INPUT = 'conference.no_audio_input',
-
     /**
      * Event indicates that the current microphone used by the conference is noisy.
      */
@@ -310,6 +287,11 @@ export enum JitsiConferenceEvents {
      */
     NON_PARTICIPANT_MESSAGE_RECEIVED = 'conference.non_participant_message_received',
 
+    /**
+     * Event indicates that the current selected input device has no signal
+     */
+    NO_AUDIO_INPUT = 'conference.no_audio_input',
+
     /**
      * Indicates that the conference has switched between JVB and P2P connections.
      * The first argument of this event is a <tt>boolean</tt> which when set to
@@ -350,12 +332,18 @@ export enum JitsiConferenceEvents {
      * New private text message was received.
      */
     PRIVATE_MESSAGE_RECEIVED = 'conference.privateMessageReceived',
+
     /**
      * The conference properties changed.
      * @type {string}
      */
     PROPERTIES_CHANGED = 'conference.propertiesChanged',
 
+    /**
+     * New reaction was received.
+     */
+    REACTION_RECEIVED = 'conference.reactionReceived',
+
     /**
      * Indicates that recording state changed.
      */
@@ -374,14 +362,14 @@ export enum JitsiConferenceEvents {
     SILENT_STATUS_CHANGED = 'conference.silentStatusChanged',
 
     /**
-     * Indicates that start muted settings changed.
+     * Indicates that the local user has started muted.
      */
-    START_MUTED_POLICY_CHANGED = 'conference.start_muted_policy_changed',
+    STARTED_MUTED = 'conference.started_muted',
 
     /**
-     * Indicates that the local user has started muted.
+     * Indicates that start muted settings changed.
      */
-    STARTED_MUTED = 'conference.started_muted',
+    START_MUTED_POLICY_CHANGED = 'conference.start_muted_policy_changed',
 
     /**
      * Indicates that subject of the conference has changed.
@@ -478,25 +466,39 @@ export enum JitsiConferenceEvents {
     VIDEO_SIP_GW_SESSION_STATE_CHANGED = 'conference.videoSIPGWSessionStateChanged',
 
     /**
-     * Event indicates that the permission for unmuting video has changed based on the number of video senders in the call
-     * and the video sender limit configured in Jicofo.
+     * Event indicates that the permission for unmuting video has changed based on the number of video senders in the
+     * call and the video sender limit configured in Jicofo.
      */
     VIDEO_UNMUTE_PERMISSIONS_CHANGED = 'conference.video_unmute_permissions_changed',
 
+    /**
+     * Event indicating we have received a message from the visitors component.
+     */
+    VISITORS_MESSAGE = 'conference.visitors_message',
+
+    /**
+     * Event indicating that our request for promotion was rejected.
+     */
+    VISITORS_REJECTION = 'conference.visitors_rejection',
+
     /**
      * Indicates that the conference has support for visitors.
      */
     VISITORS_SUPPORTED_CHANGED = 'conference.visitorsSupported',
 
     /**
-     * Event indicating we have received a message from the visitors component.
+     * An event(library-private) fired when the conference switches the currently active media session.
+     * @type {string}
+     * @private
      */
-    VISITORS_MESSAGE = 'conference.visitors_message',
+    _MEDIA_SESSION_ACTIVE_CHANGED = 'conference.media_session.active_changed',
 
     /**
-     * Event indicating that our request for promotion was rejected.
+     * An event(library-private) fired when a new media session is added to the conference.
+     * @type {string}
+     * @private
      */
-    VISITORS_REJECTION = 'conference.visitors_rejection'
+    _MEDIA_SESSION_STARTED = 'conference.media_session.started'
 }
 
 // exported for backward compatibility

JitsiConnectionErrors.ts

@@ -3,10 +3,11 @@
  */
 
 export enum JitsiConnectionErrors {
+
     /**
      * When the conference-request to jicofo fails.
      */
-    CONFERENCE_REQUEST_FAILED = "connection.conferenceRequestFailed",
+    CONFERENCE_REQUEST_FAILED = 'connection.conferenceRequestFailed',
 
     /**
      * Indicates that the connection was dropped with an error which was most likely
@@ -41,7 +42,7 @@ export enum JitsiConnectionErrors {
      * errors on BOSH requests.
      */
     SERVER_ERROR = 'connection.serverError'
-};
+}
 
 // exported for backward compatibility
 export const CONFERENCE_REQUEST_FAILED = JitsiConnectionErrors.CONFERENCE_REQUEST_FAILED;

JitsiConnectionEvents.ts

@@ -3,6 +3,7 @@
  */
 
 export enum JitsiConnectionEvents {
+
     /**
      * Indicates that the connection has been disconnected. The event provides
      * the following parameters to its listeners:
@@ -39,12 +40,6 @@ export enum JitsiConnectionEvents {
      */
     CONNECTION_REDIRECTED = 'connection.redirected',
 
-    /**
-     * Indicates that the performed action cannot be executed because the
-     * connection is not in the correct state(connected, disconnected, etc.)
-     */
-    WRONG_STATE = 'connection.wrongState',
-
     /**
      * Indicates that the display name is required over this connection and need to be supplied when
      * joining the room.
@@ -56,7 +51,13 @@ export enum JitsiConnectionEvents {
      * Indicates that the connection properties have been updated.
      * @param properties {object} - All available connection properties (e.g. shard, region).
      */
-    PROPERTIES_UPDATED = 'connection.propertiesUpdated'
+    PROPERTIES_UPDATED = 'connection.propertiesUpdated',
+
+    /**
+     * Indicates that the performed action cannot be executed because the
+     * connection is not in the correct state(connected, disconnected, etc.)
+     */
+    WRONG_STATE = 'connection.wrongState'
 }
 
 // exported for backward compatibility

JitsiMediaDevicesEvents.ts

@@ -3,6 +3,7 @@
  */
 
 export enum JitsiMediaDevicesEvents {
+
     /**
      * Indicates that the list of available media devices has been changed. The
      * event provides the following parameters to its listeners:
@@ -30,7 +31,7 @@ export enum JitsiMediaDevicesEvents {
      *  other execution environment.
      */
     PERMISSION_PROMPT_IS_SHOWN = 'mediaDevices.permissionPromptIsShown'
-};
+}
 
 // exported for backward compatibility
 export const DEVICE_LIST_CHANGED = JitsiMediaDevicesEvents.DEVICE_LIST_CHANGED;