Add/update linting and code style

* Add rubocop linting
* Add editorconfig for consistent file formatting
* Fix code style issues (ignore complexity on main function for now)

Author: jgraichen

.editorconfig

@@ -0,0 +1,12 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true

.rubocop.yml

@@ -1,53 +1,55 @@
 AllCops:
   Include:
     - '**/*.rb'
-  TargetRubyVersion: 2.1
+  NewCops: enable
+  SuggestExtensions: false
+  TargetRubyVersion: 2.4
+
+Layout/CaseIndentation:
+  EnforcedStyle: end
+  IndentOneStep: true
+  SupportedStyles:
+    - case
+    - end
+
+Layout/ArgumentAlignment:
+  EnforcedStyle: with_fixed_indentation
+
+Layout/SpaceInsideBlockBraces:
+  EnforcedStyle: space
+  EnforcedStyleForEmptyBraces: no_space
+  SpaceBeforeBlockParameters: false
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
 
 Metrics/BlockLength:
   Exclude:
-    - 'spec/**/*_spec.rb'
+    - Rakefile
+    - spec/**/*_spec.rb
 
 Metrics/LineLength:
   Exclude:
-    - 'spec/**/*_spec.rb'
+    - spec/**/*_spec.rb
 
-Style/AlignParameters:
-  EnforcedStyle: with_fixed_indentation
 
-Style/BracesAroundHashParameters:
-  EnforcedStyle: context_dependent
+Naming/FileName:
+  Exclude:
+    - lib/rails-timeago.rb
 
-Style/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
 
-Style/RaiseArgs:
-  EnforcedStyle: compact
+Style/ClassAndModuleChildren:
+  Enabled: false
 
 Style/Documentation:
   Enabled: false
 
-Style/SpaceInsideBlockBraces:
-  EnforcedStyle: space
-  EnforcedStyleForEmptyBraces: no_space
-  SpaceBeforeBlockParameters: false
+Style/RaiseArgs:
+  EnforcedStyle: compact
 
 Style/SignalException:
   EnforcedStyle: only_raise
 
-Style/CaseIndentation:
-  EnforcedStyle: end
-  SupportedStyles:
-    - case
-    - end
-  IndentOneStep: true
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
 Style/TrivialAccessors:
   AllowPredicates: true
-
-Style/FileName:
-  Exclude:
-    - Rakefile
-    - Gemfile

Gemfile

@@ -8,6 +8,9 @@ gemspec
 group :development do
   gem 'rake'
   gem 'rake-release'
+
+  gem 'rubocop', '~> 1.7'
+  gem 'rubocop-rspec', '~> 1.42'
 end
 
 group :test do

lib/rails-timeago/helper.rb

@@ -40,15 +40,22 @@ module Helper
       #
       # All other options will be given as options to tag helper.
       #
+      # rubocop:disable Metrics/AbcSize
+      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/PerceivedComplexity
       def timeago_tag(time, html_options = {})
         time_options = Rails::Timeago.default_options
 
-        time_options = time_options.merge html_options.extract!(*time_options.keys.select {|k| html_options.include?(k) })
+        time_options = time_options.merge html_options.extract!(*time_options.keys.select do |k|
+                                                                  html_options.include?(k)
+                                                                end)
         return time_options[:default] if time.nil?
 
         time_options[:format] = time_options[:format].call(time, time_options) if time_options[:format].is_a?(Proc)
         if time_options[:title]
-          html_options[:title] = time_options[:title].is_a?(Proc) ? time_options[:title].call(time, time_options) : time_options[:title]
+          html_options[:title] =
+            time_options[:title].is_a?(Proc) ? time_options[:title].call(time, time_options) : time_options[:title]
         end
         time_options[:limit] = time_options[:limit].call if time_options[:limit].is_a?(Proc)
 
@@ -63,10 +70,16 @@ def timeago_tag(time, html_options = {})
         end
         time_tag time, timeago_tag_content(time, time_options), html_options
       end
+      # rubocop:enable Metrics/PerceivedComplexity
+      # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/CyclomaticComplexity
+      # rubocop:enable Metrics/AbcSize
 
       def timeago_tag_content(time, time_options = {}) # :nodoc:
-        time = time.to_date            if time_options[:date_only]
-        return time_ago_in_words(time) if time_options[:nojs] && (time_options[:limit].nil? || time_options[:limit] < time)
+        time = time.to_date if time_options[:date_only]
+        if time_options[:nojs] && (time_options[:limit].nil? || time_options[:limit] < time)
+          return time_ago_in_words(time)
+        end
 
         I18n.l time, format: time_options[:format]
       end