Skip to content

Commit b18cb45

Browse files
committed
Add BUILD_BYPRODUCTS to ExternalProject_Add for building with Ninja
IoT.js-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]
1 parent 7fdafb0 commit b18cb45

File tree

3 files changed

+26
-5
lines changed

3 files changed

+26
-5
lines changed

cmake/http-parser.cmake

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ ExternalProject_Add(http-parser
3838
-DOS=${TARGET_OS}
3939
${HTTPPARSER_NUTTX_ARG}
4040
-DENABLE_MEMORY_CONSTRAINTS=ON
41+
BUILD_BYPRODUCTS ${CMAKE_BINARY_DIR}/lib/${HTTPPARSER_NAME}
4142
)
4243
add_library(libhttp-parser STATIC IMPORTED)
4344
add_dependencies(libhttp-parser http-parser)

cmake/jerry.cmake

+24-4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,14 @@ cmake_minimum_required(VERSION 2.8)
1616

1717
# Host jerry for snapshot generation
1818
set(DEPS_HOST_JERRY deps/jerry-host)
19+
20+
set(JERRY_HOST_SNAPSHOT
21+
${CMAKE_BINARY_DIR}/${DEPS_HOST_JERRY}/bin/jerry-snapshot)
22+
23+
set(JERRY_HOST_BUILD_BYPRODUCTS
24+
${JERRY_HOST_SNAPSHOT}
25+
)
26+
1927
ExternalProject_Add(hostjerry
2028
PREFIX ${DEPS_HOST_JERRY}
2129
SOURCE_DIR ${ROOT_DIR}/deps/jerry/
@@ -45,9 +53,8 @@ ExternalProject_Add(hostjerry
4553
# can not be represented correctly in the JerryScript engine
4654
# currently.
4755
-DJERRY_SYSTEM_ALLOCATOR=OFF
56+
BUILD_BYPRODUCTS ${JERRY_HOST_BUILD_BYPRODUCTS}
4857
)
49-
set(JERRY_HOST_SNAPSHOT
50-
${CMAKE_BINARY_DIR}/${DEPS_HOST_JERRY}/bin/jerry-snapshot)
5158
add_executable(jerry-snapshot IMPORTED)
5259
add_dependencies(jerry-snapshot hostjerry)
5360
set_property(TARGET jerry-snapshot PROPERTY
@@ -118,6 +125,20 @@ separate_arguments(EXTRA_JERRY_CMAKE_PARAMS)
118125
build_lib_name(JERRY_CORE_NAME jerry-core)
119126
build_lib_name(JERRY_LIBM_NAME jerry-libm)
120127
build_lib_name(JERRY_EXT_NAME jerry-ext)
128+
build_lib_name(JERRY_PORT_NAME jerry-port)
129+
build_lib_name(JERRY_PORT_DEFAULT_NAME jerry-port-default)
130+
131+
set(JERRY_BUILD_BYPRODUCTS
132+
${CMAKE_BINARY_DIR}/lib/${JERRY_CORE_NAME}
133+
${CMAKE_BINARY_DIR}/lib/${JERRY_LIBM_NAME}
134+
${CMAKE_BINARY_DIR}/lib/${JERRY_EXT_NAME}
135+
)
136+
137+
if(NOT "${TARGET_OS}" MATCHES "NUTTX|TIZENRT")
138+
list(APPEND JERRY_BUILD_BYPRODUCTS
139+
${CMAKE_BINARY_DIR}/lib/${JERRY_PORT_DEFAULT_NAME})
140+
endif()
141+
121142

122143
set(DEPS_LIB_JERRY deps/jerry)
123144
set(DEPS_LIB_JERRY_SRC ${ROOT_DIR}/${DEPS_LIB_JERRY})
@@ -146,6 +167,7 @@ ExternalProject_Add(libjerry
146167
-DENABLE_LTO=${ENABLE_LTO}
147168
${DEPS_LIB_JERRY_ARGS}
148169
${EXTRA_JERRY_CMAKE_PARAMS}
170+
BUILD_BYPRODUCTS ${JERRY_BUILD_BYPRODUCTS}
149171
)
150172

151173
set_property(DIRECTORY APPEND PROPERTY
@@ -174,8 +196,6 @@ set_property(TARGET jerry-ext PROPERTY
174196
IMPORTED_LOCATION ${CMAKE_BINARY_DIR}/lib/${JERRY_EXT_NAME})
175197

176198
if(NOT "${TARGET_OS}" MATCHES "NUTTX|TIZENRT")
177-
build_lib_name(JERRY_PORT_NAME jerry-port)
178-
build_lib_name(JERRY_PORT_DEFAULT_NAME jerry-port-default)
179199
set_property(DIRECTORY APPEND PROPERTY
180200
ADDITIONAL_MAKE_CLEAN_FILES
181201
${CMAKE_BINARY_DIR}/lib/${JERRY_PORT_NAME}

cmake/libtuv.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ ExternalProject_Add(libtuv
4646
-DBUILDAPIEMULTESTER=NO
4747
-DTARGET_SYSTEMROOT=${TARGET_SYSTEMROOT}
4848
-DTARGET_BOARD=${TARGET_BOARD}
49+
BUILD_BYPRODUCTS ${CMAKE_BINARY_DIR}/lib/${LIBTUV_NAME}
4950
)
5051
add_library(tuv STATIC IMPORTED)
51-
add_dependencies(tuv libtuv)
5252
set_property(TARGET tuv PROPERTY
5353
IMPORTED_LOCATION ${CMAKE_BINARY_DIR}/lib/${LIBTUV_NAME})
5454
set_property(DIRECTORY APPEND PROPERTY

0 commit comments

Comments
 (0)