From 20a84c52c9e2e49b5e0f6b95af1eb1b7fb902f65 Mon Sep 17 00:00:00 2001 From: Julien <364924+Bahanix@users.noreply.github.com> Date: Mon, 11 Nov 2024 12:33:14 +0100 Subject: [PATCH] Nullify MySQL comments if empty --- lib/sequel/adapters/shared/mysql.rb | 1 + spec/adapters/mysql_spec.rb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/sequel/adapters/shared/mysql.rb b/lib/sequel/adapters/shared/mysql.rb index 9d5e91228..35d93a299 100644 --- a/lib/sequel/adapters/shared/mysql.rb +++ b/lib/sequel/adapters/shared/mysql.rb @@ -578,6 +578,7 @@ def schema_parse_table(table_name, opts) end row[:allow_null] = row.delete(:Null) == 'YES' row[:comment] = row.delete(:Comment) + row[:comment] = nil if row[:comment] == "" row[:default] = row.delete(:Default) row[:db_type] = row.delete(:Type) row[:type] = schema_column_type(row[:db_type]) diff --git a/spec/adapters/mysql_spec.rb b/spec/adapters/mysql_spec.rb index a1a759e04..9c4f77048 100644 --- a/spec/adapters/mysql_spec.rb +++ b/spec/adapters/mysql_spec.rb @@ -48,7 +48,7 @@ Integer :b end @db.run("ALTER TABLE dolls CHANGE b b INT COMMENT 'blah'") - @db.schema(:dolls).map{|k, v| v[:comment]}.must_equal ["", 'blah'] + @db.schema(:dolls).map{|k, v| v[:comment]}.must_equal [nil, 'blah'] end it "should include an :auto_increment schema attribute if auto incrementing" do