Skip to content

Commit

Permalink
Merge pull request #7 from jdee/fix-target-parameter
Browse files Browse the repository at this point in the history
fix #5: Bad key for :target option. Added unit tests for options.
  • Loading branch information
jdee authored Apr 21, 2017
2 parents 78354f0 + 313ee77 commit 1daa47b
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
fastlane-plugin-settings_bundle (1.1.0)
fastlane-plugin-settings_bundle (1.1.1)
plist
xcodeproj (>= 1.4.0)

Expand Down
28 changes: 28 additions & 0 deletions spec/update_settings_bundle_action_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,34 @@
end
end

describe 'options' do
let(:options) { action.available_options }

it 'includes a :xcodeproj option' do
expect(options.find { |o| o.key == :xcodeproj && o.env_name == "SETTINGS_BUNDLE_XCODEPROJ" }).not_to be_nil
end

it 'includes a :key option' do
expect(options.find { |o| o.key == :key && o.env_name == "SETTINGS_BUNDLE_KEY" }).not_to be_nil
end

it 'includes a :value option' do
expect(options.find { |o| o.key == :value && o.env_name == "SETTINGS_BUNDLE_VALUE" }).not_to be_nil
end

it 'includes a :configuration option' do
expect(options.find { |o| o.key == :configuration && o.env_name == "SETTINGS_BUNDLE_CONFIGURATION" }).not_to be_nil
end

it 'includes a :file option' do
expect(options.find { |o| o.key == :file && o.env_name == "SETTINGS_BUNDLE_FILE" }).not_to be_nil
end

it 'includes a :target option' do
expect(options.find { |o| o.key == :target && o.env_name == "SETTINGS_BUNDLE_TARGET" }).not_to be_nil
end
end

# Satisfy simplecov
describe 'other methods' do
it 'has examples' do
Expand Down

0 comments on commit 1daa47b

Please sign in to comment.