Skip to content

Commit 6c0a529

Browse files
authored
Merge pull request #92 from jbossas/eap8-dev
Support JDK 21 images for EAP 8.0
2 parents a34b613 + bf2f8f8 commit 6c0a529

File tree

4 files changed

+27
-8
lines changed

4 files changed

+27
-8
lines changed

charts/eap8/README.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,11 @@ If the application image has been built by another mechanism, you can skip the b
137137
| `build.s2i.galleonDir` | Directory relative to the root directory for the build that contains custom content for Galleon. | - | [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.4/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) |
138138
| `build.s2i.featurePacks` | List of additional Galleon feature-packs identified by Maven coordinates (`<groupId>:<artifactId>:<version>`) | - | The value can be be either a `string` with a list of comma-separated Maven coordinate or an array where each item is the Maven coordinate of a feature pack - [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.4/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) |
139139
| `build.s2i.channels` | List of Channels identified by Maven coordinates (`<groupId>:<artifactId>`). If featurePacks are configured without any versioning, the channels that provides the latest feature packs can be specified. Deprecated, the recommended way to provision EAP is to use the eap-maven-plugin in the application pom.xml | - | The value can be be either a `string` with a list of comma-separated Maven coordinate or an array where each item is the Maven coordinate of a channel - [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.4/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) |
140-
| `build.s2i.jdk` | JDK Version of the EAP S2I images | `"17"` | Allowed Values: `"17"` |
140+
| `build.s2i.jdk` | JDK Version of the EAP S2I images | `"17"` | Allowed Values: `"17", "21"` |
141141
| `build.s2i.jdk17.builderImage` | EAP S2I Builder image for JDK 17 | `registry.redhat.io/jboss-eap-8/eap8-openjdk17-builder-openshift-rhel8:latest` | [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/8.0/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) |
142142
| `build.s2i.jdk17.runtimeImage` | EAP S2I Runtime image for JDK 17| `registry.redhat.io/jboss-eap-8/eap8-openjdk17-runtime-openshift-rhel8:latest` | [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/8.0/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) |
143+
| `build.s2i.jdk21.builderImage` | EAP S2I Builder image for JDK 21 | `registry.redhat.io/jboss-eap-8/eap8-openjdk21-builder-openshift-rhel9:latest` | [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/8.0/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) |
144+
| `build.s2i.jdk21.runtimeImage` | EAP S2I Runtime image for JDK 21| `registry.redhat.io/jboss-eap-8/eap8-openjdk21-runtime-openshift-rhel9:latest` | [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/8.0/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) |
143145
| `build.s2i.kind` | Determines the type of images for S2I Builder and Runtime images (`DockerImage`, `ImageStreamTag` or `ImageStreamImage`) | `DockerImage` | [OKD Documentation](https://docs.okd.io/latest/cicd/builds/build-strategies.html#builds-strategy-s2i-build_build-strategies) |
144146
| `build.s2i.runtimeKind` | Determines the type of images for S2I Runtime image (`DockerImage`, `ImageStreamTag` or `ImageStreamImage`) | the value of `build.s2i.kind` | [OKD Documentation](https://docs.okd.io/latest/cicd/)|
145147
| `build.sourceSecret`|Name of the secret containing the credentials to login to Git source reposiory | - | The secret must exist in the same namespace or the chart will fail to install - [OKD documentation](https://docs.okd.io/latest/cicd/builds/creating-build-inputs.html#builds-manually-add-source-clone-secrets_creating-build-inputs) |

charts/eap8/templates/_helpers.tpl

+6-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ eap8.eapBuilderImage corresponds to the imagestream for the EAP S2I Builder imag
44
It depends on the build.s2i.jdk version.
55
*/}}
66
{{- define "eap8.eapBuilderImage" -}}
7-
{{- if eq .Values.build.s2i.jdk "11" -}}
8-
{{ .Values.build.s2i.jdk11.builderImage}}
9-
{{- else -}}
7+
{{- if eq .Values.build.s2i.jdk "17" -}}
108
{{ .Values.build.s2i.jdk17.builderImage}}
9+
{{- else -}}
10+
{{ .Values.build.s2i.jdk21.builderImage}}
1111
{{- end -}}
1212
{{- end -}}
1313

@@ -16,10 +16,10 @@ eap8.eapRuntimeImage corresponds to the imagestream for the EAP S2I Runtime imag
1616
It depends on the build.s2i.jdkVersion.
1717
*/}}
1818
{{- define "eap8.eapRuntimeImage" -}}
19-
{{- if eq .Values.build.s2i.jdk "11" -}}
20-
{{ .Values.build.s2i.jdk11.runtimeImage}}
21-
{{- else -}}
19+
{{- if eq .Values.build.s2i.jdk "17" -}}
2220
{{ .Values.build.s2i.jdk17.runtimeImage}}
21+
{{- else -}}
22+
{{ .Values.build.s2i.jdk21.runtimeImage}}
2323
{{- end -}}
2424
{{- end -}}
2525

charts/eap8/values.schema.json

+15-1
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@
234234
"jdk": {
235235
"description": "JDK Version of the EAP S2I images",
236236
"type": "string",
237-
"enum": ["17"],
237+
"enum": ["17", "21"],
238238
"default": "17"
239239
},
240240
"jdk17": {
@@ -248,6 +248,20 @@
248248
"runtimeImage": {
249249
"description": "EAP S2I Runtime image for JDK 17",
250250
"type": "string"
251+
}
252+
}
253+
},
254+
"jdk21": {
255+
"description": "EAP S2I images for JDK 21",
256+
"type": "object",
257+
"properties": {
258+
"builderImage": {
259+
"description": "EAP S2I Builder image for JDK 21",
260+
"type": "string"
261+
},
262+
"runtimeImage": {
263+
"description": "EAP S2I Runtime image for JDK 21",
264+
"type": "string"
251265
}
252266
}
253267
},

charts/eap8/values.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ build:
1515
jdk17:
1616
builderImage: registry.redhat.io/jboss-eap-8/eap8-openjdk17-builder-openshift-rhel8:latest
1717
runtimeImage: registry.redhat.io/jboss-eap-8/eap8-openjdk17-runtime-openshift-rhel8:latest
18+
jdk21:
19+
builderImage: registry.redhat.io/jboss-eap-8/eap8-openjdk21-builder-openshift-rhel9:latest
20+
runtimeImage: registry.redhat.io/jboss-eap-8/eap8-openjdk21-runtime-openshift-rhel9:latest
1821
output:
1922
kind: "ImageStreamTag"
2023
triggers: {}

0 commit comments

Comments
 (0)