Improve missing value handling logic of ptable_heatmap
#241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve missing value handling logic of
ptable_heatmap
Our
ptable_heatmap
has suboptimal missing value handling logic, to close #230:PTableData
typed data would be converted, but with themissing_strategy
hard-coded asmean
, meaning we're artificially creating non-existent data by default also user cannot control this behaviour, perhaps showing missing value as is (-
) would be better.on_empty
sort of overlaps, perhaps we could partly reuse it)1000
level)TODO list:
NaN/None
PTableData
and others (pd.DataFrame
) when containing missing values (NaN/None)