Skip to content

Commit 821a515

Browse files
authored
Merge pull request #19 from jakzal/ignore-base-test-case
Ignore the base phpunit test case during property extraction
2 parents 9b9b57b + 57c13ab commit 821a515

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

Diff for: composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"php": "^7.2",
77
"phpunit/phpunit": "^8.0",
88
"psr/container": "^1.0",
9-
"zalas/injector": "^1.0"
9+
"zalas/injector": "^1.2"
1010
},
1111
"require-dev": {
1212
"symfony/config": "^3.4 || ^4.0",

Diff for: depfile.yml

+1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ ruleset:
7575
Symfony Compiler:
7676
- Injector Factory
7777
- Injector Service
78+
- PHPUnit
7879
- TestCase
7980
- Symfony Config
8081
- Symfony DependencyInjection

Diff for: src/Symfony/Compiler/Discovery/PropertyDiscovery.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
namespace Zalas\Injector\PHPUnit\Symfony\Compiler\Discovery;
55

6+
use PHPUnit\Framework\Assert;
7+
use PHPUnit\Framework\TestCase;
68
use Zalas\Injector\Factory\DefaultExtractorFactory;
79
use Zalas\Injector\PHPUnit\TestCase\ServiceContainerTestCase;
810
use Zalas\Injector\Service\ExtractorFactory;
@@ -23,7 +25,7 @@ class PropertyDiscovery
2325
public function __construct(?ClassFinder $classFinder = null, ?ExtractorFactory $extractorFactory = null)
2426
{
2527
$this->classFinder = $classFinder ?? new ClassFinder();
26-
$this->extractorFactory = $extractorFactory ?? new DefaultExtractorFactory();
28+
$this->extractorFactory = $extractorFactory ?? new DefaultExtractorFactory([TestCase::class, Assert::class]);
2729
}
2830

2931
/**

Diff for: src/TestListener/ServiceInjectorListener.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
namespace Zalas\Injector\PHPUnit\TestListener;
55

6+
use PHPUnit\Framework\Assert;
67
use PHPUnit\Framework\Test;
8+
use PHPUnit\Framework\TestCase;
79
use PHPUnit\Framework\TestListener;
810
use PHPUnit\Framework\TestListenerDefaultImplementation;
911
use Zalas\Injector\Factory\DefaultExtractorFactory;
@@ -17,7 +19,7 @@ class ServiceInjectorListener implements TestListener
1719
public function startTest(Test $test): void
1820
{
1921
if ($test instanceof ServiceContainerTestCase) {
20-
$injector = new Injector(new TestCaseContainerFactory($test), new DefaultExtractorFactory());
22+
$injector = new Injector(new TestCaseContainerFactory($test), new DefaultExtractorFactory([TestCase::class, Assert::class]));
2123
$injector->inject($test);
2224
}
2325
}

0 commit comments

Comments
 (0)