forked from python-trio/flake8-async
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathasync910.py
637 lines (451 loc) · 12.3 KB
/
async910.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
# AUTOFIX
# ASYNCIO_NO_AUTOFIX
# mypy: disable-error-code="unreachable"
from __future__ import annotations
import contextlib
import typing
from typing import Any, overload
import pytest
import trio
_ = ""
custom_disabled_decorator: Any = ...
async def foo() -> Any:
await foo()
def bar() -> Any: ...
# ARG --enable=ASYNC910,ASYNC911
# ARG --no-checkpoint-warning-decorator=custom_disabled_decorator
# function whose body solely consists of pass, ellipsis, or string constants is safe
# fmt: off
async def foo_empty_1a():
...
async def foo_empty_1b(): ...
async def foo_empty_1c(): ...; ...
# fmt: on
async def foo_empty_2():
pass
async def foo_empty_3():
"""comment"""
async def foo_empty_4():
...
"""comment"""
...
"""comment2"""
async def foo1(): # error: 0, "exit", Statement("function definition", lineno)
bar()
await trio.lowlevel.checkpoint()
# If
async def foo_if_1(): # error: 0, "exit", Statement("function definition", lineno)
if _:
await foo()
await trio.lowlevel.checkpoint()
async def foo_if_2():
if _:
await foo()
else:
await foo()
async def foo_if_3():
await foo()
if _:
...
async def foo_if_4(): # safe
await foo()
if ...:
...
else:
...
# IfExp
async def foo_ifexp_1(): # safe
print(await foo() if _ else await foo())
async def foo_ifexp_2(): # error: 0, "exit", Statement("function definition", lineno)
print(_ if False and await foo() else await foo())
await trio.lowlevel.checkpoint()
# nested function definition
async def foo_func_1():
await foo()
async def foo_func_2(): # error: 4, "exit", Statement("function definition", lineno)
bar()
await trio.lowlevel.checkpoint()
# we don't get a newline after the nested function definition before the checkpoint
# when autofixing
# fmt: off
async def foo_func_3(): # error: 0, "exit", Statement("function definition", lineno)
async def foo_func_4():
await foo()
await trio.lowlevel.checkpoint()
async def foo_func_5(): # error: 0, "exit", Statement("function definition", lineno)
def foo_func_6(): # safe
async def foo_func_7(): # error: 8, "exit", Statement("function definition", lineno)
bar()
await trio.lowlevel.checkpoint()
await trio.lowlevel.checkpoint()
async def foo_func_8(): # error: 0, "exit", Statement("function definition", lineno)
def foo_func_9():
raise
await trio.lowlevel.checkpoint()
# fmt: on
# normal function
def foo_normal_func_1():
return
def foo_normal_func_2(): ...
# overload decorator is skipped
# overload functions should always be empty, so the check is somewhat redundant,
# but making one non-empty to check the logic.
@overload
async def foo_overload_1(_: bytes):
raise NotImplementedError
@typing.overload
async def foo_overload_1(_: str): ...
async def foo_overload_1(_: bytes | str):
await foo()
# conditions
async def foo_condition_1(): # safe
if await foo():
...
async def foo_condition_2(): # error: 0, "exit", Statement("function definition", lineno)
if False and await foo():
...
await trio.lowlevel.checkpoint()
async def foo_condition_3(): # error: 0, "exit", Statement("function definition", lineno)
if ... and await foo():
...
await trio.lowlevel.checkpoint()
async def foo_condition_4(): # safe
while await foo():
...
async def foo_condition_5(): # safe
for i in await foo():
...
async def foo_condition_6(): # in theory error, but not worth parsing
for i in (None, await foo()):
break
# loops
async def foo_while_1(): # error: 0, "exit", Statement("function definition", lineno)
while _:
await foo()
await trio.lowlevel.checkpoint()
async def foo_while_2(): # now safe
while _:
await foo()
else:
await foo()
async def foo_while_3(): # safe
await foo()
while _:
...
async def foo_while_4(): # error: 0, "exit", Statement("function definition", lineno)
while False:
await foo()
await trio.lowlevel.checkpoint()
# for
async def foo_for_1(): # error: 0, "exit", Statement("function definition", lineno)
for _ in "":
await foo()
await trio.lowlevel.checkpoint()
async def foo_for_2(): # now safe
for _ in "":
await foo()
else:
await foo()
async def foo_while_break_1(): # safe
while bar():
await foo()
break
else:
await foo()
async def foo_while_break_2(): # error: 0, "exit", Statement("function definition", lineno)
while bar():
break
else:
await foo()
await trio.lowlevel.checkpoint()
async def foo_while_break_3(): # error: 0, "exit", Statement("function definition", lineno)
while bar():
await foo()
break
else:
...
await trio.lowlevel.checkpoint()
async def foo_while_break_4(): # error: 0, "exit", Statement("function definition", lineno)
while bar():
break
else:
...
await trio.lowlevel.checkpoint()
async def foo_while_continue_1(): # safe
while bar():
await foo()
continue
else:
await foo()
async def foo_while_continue_2(): # safe
while bar():
continue
else:
await foo()
async def foo_while_continue_3(): # error: 0, "exit", Statement("function definition", lineno)
while bar():
await foo()
continue
else:
...
await trio.lowlevel.checkpoint()
async def foo_while_continue_4(): # error: 0, "exit", Statement("function definition", lineno)
while bar():
continue
else:
...
await trio.lowlevel.checkpoint()
async def foo_async_for_1():
async for _ in bar():
...
# async with
# async with guarantees checkpoint on at least one of entry or exit
async def foo_async_with():
async with bar():
...
# raise
async def foo_raise_1(): # safe
raise ValueError()
async def foo_raise_2(): # safe
if _:
await foo()
else:
raise ValueError()
# try
# safe only if (try or else) and all except bodies either await or raise
# if `foo()` raises a ValueError it's not checkpointed
async def foo_try_1(): # error: 0, "exit", Statement("function definition", lineno)
try:
await foo()
except ValueError:
...
except:
raise
else:
await foo()
await trio.lowlevel.checkpoint()
async def foo_try_2(): # safe
try:
...
except ValueError:
...
except:
raise
finally:
await foo()
async def foo_try_3(): # safe
try:
await foo()
except ValueError:
await foo()
except:
raise
async def foo_try_4(): # safe
try:
...
except ValueError:
raise
except:
raise
else:
await foo()
async def foo_try_5(): # safe
await foo()
try:
pass
except:
pass
else:
pass
async def foo_try_6(): # error: 0, "exit", Statement("function definition", lineno)
try:
pass
except:
pass
else:
pass
await trio.lowlevel.checkpoint()
async def foo_try_7(): # safe
try:
await foo()
except:
await foo()
else:
pass
# https://github.com/python-trio/flake8-async/issues/45
async def to_queue(iter_func, queue):
async with iter_func() as it:
async for x in it:
queue.put(x)
async def to_queue2(iter_func, queue):
try:
async with iter_func() as it:
async for x in it:
queue.put(x)
finally:
queue.put(None)
# safe, exception is propagated out
async def try_checkpoint_empty_finally():
try:
await trio.sleep(0)
finally:
...
# unsafe, exception is suppressed
async def try_exception_suppressed(): # error: 0, 'exit', Statement('function definition', lineno)
try:
await trio.sleep(0)
except:
...
await trio.lowlevel.checkpoint()
# safe
async def try_bare_except_reraises():
try:
await trio.sleep(0)
except:
raise
finally:
...
async def return_in_finally_bare_except_checkpoint():
try:
await trio.sleep(0)
except:
await trio.sleep(0)
finally:
return
async def return_in_finally_bare_except_empty():
try:
await trio.sleep(0)
except:
...
finally:
await trio.lowlevel.checkpoint()
return # error: 8, 'return', Statement('function definition', lineno-6)
# early return
async def foo_return_1():
await trio.lowlevel.checkpoint()
return # error: 4, "return", Statement("function definition", lineno-1)
async def foo_return_2(): # safe
if _:
await trio.lowlevel.checkpoint()
return # error: 8, "return", Statement("function definition", lineno-2)
await foo()
async def foo_return_3(): # error: 0, "exit", Statement("function definition", lineno)
if _:
await foo()
return # safe
await trio.lowlevel.checkpoint()
# loop over non-empty static collection
async def foo_loop_static():
for i in [1, 2, 3]:
await foo()
# also handle range with constants
async def foo_range_1():
for i in range(5):
await foo()
async def foo_range_2():
for i in range(5, 10):
await foo()
async def foo_range_3():
for i in range(10, 5, -1):
await foo()
async def foo_range_4(): # error: 0, "exit", Statement("function definition", lineno)
for i in range(10, 5):
await foo()
await trio.lowlevel.checkpoint()
# error on complex parameters
async def foo_range_5(): # error: 0, "exit", Statement("function definition", lineno)
for i in range(3 - 2):
await foo()
await trio.lowlevel.checkpoint()
# https://github.com/python-trio/flake8-async/issues/47
async def f():
while True:
if ...:
await trio.sleep(0)
return
# If you delete this loop, no warning.
while bar():
await foo()
async def f1():
while True:
if ...:
await trio.sleep(0)
return
async def f2():
while True:
await trio.sleep(0)
return
# code coverage
def foo_sync():
# try in sync function
try:
pass
except:
pass
# continue/break in sync function
while True:
if ...:
continue
if ...:
break
# boolop in sync function
True and True # type: ignore
# don't warn on pytest.fixture
@pytest.fixture
async def foo_test():
print("...")
@pytest.fixture()
async def foo_test2():
print("...")
@custom_disabled_decorator
async def foo_ARG_test():
print("...")
@custom_disabled_decorator()
async def foo_ARG_test2():
print("...")
@pytest.fixture
async def foo_test_return():
return
@pytest.fixture()
async def foo_test_return2():
return
async def foo_comprehension_1():
[... for x in range(10) if await foo()]
# should error
async def foo_comprehension_2(): # error: 0, "exit", Statement("function definition", lineno)
[await foo() for x in range(10) if bar()]
await trio.lowlevel.checkpoint()
async def foo_comprehension_3():
[... async for x in bar()]
# Issue #714
# (await x async for y in await z)
# ^ ^ ^ this always runs!
# ^ ^ this might not run
# ^ this might not run
async def await_in_gen_target():
(print(x) for x in await foo())
async def await_everywhere_except_gen_target(): # error: 0, "exit", Statement("function definition", lineno)
(await x async for x in bar())
await trio.lowlevel.checkpoint()
# Issue #226
async def fn_226(): # error: 0, "exit", Statement("function definition", lineno)
try:
while foo():
try:
await trio.sleep(1)
except Exception:
pass
except Exception:
pass
await trio.lowlevel.checkpoint()
# the await() is evaluated in the parent scope
async def foo_default_value_await():
async def bar( # error: 4, "exit", Statement("function definition", lineno)
arg=await foo(),
):
print()
await trio.lowlevel.checkpoint()
async def foo_nested_empty_async():
# this previously errored because leave_FunctionDef assumed a non-empty body
async def bar(): ...
await foo()