From 6e9de9dd427d0d52566a1854307154b5f3623bac Mon Sep 17 00:00:00 2001
From: Jake Walsh <37653943+jakewalsh90@users.noreply.github.com>
Date: Wed, 11 Oct 2023 08:22:40 +0100
Subject: [PATCH] TF Cloud Lab Elements

---
 Core-Environment-DemoLab-v1/readme.md | 10 ++++----
 Terraform-Cloud-Labs/.gitignore       | 33 ---------------------------
 2 files changed, 4 insertions(+), 39 deletions(-)
 delete mode 100644 Terraform-Cloud-Labs/.gitignore

diff --git a/Core-Environment-DemoLab-v1/readme.md b/Core-Environment-DemoLab-v1/readme.md
index 9105d9b..8b1e4a0 100644
--- a/Core-Environment-DemoLab-v1/readme.md
+++ b/Core-Environment-DemoLab-v1/readme.md
@@ -1,6 +1,8 @@
 This lab is an environment that I deploy with Terraform Cloud to quickly get an Azure Environment up and running - allowing me to demonstrate concepts and test ideas. 
 
-These labs can also be used other deployment methods, but the guide below is for Terraform Cloud. Follow the pre-reqs below to deploy. 
+These labs can also be used with other deployment methods and tooling, but the guide below is for Terraform Cloud. Follow the notes below to deploy. 
+
+For a guide on setting up a Service Principal see here: https://github.com/jakewalsh90/Terraform-Azure/tree/main/Terraform-Cloud-Deployment
 
 ## Pre reqs:
 
@@ -11,9 +13,5 @@ The following elements need to be added to Terraform Cloud as variables:
  - client_id - Service Principal ID
  - client_secret - Service Principal Secret
  - subscription_id - Subscription ID you want to deploy into
- - tenant_id - Tenant ID
-
-### Lab Specific Variables
-
-##### Core Environment
+ - tenant_id - Tenant ID of the Azure Tenant you want to deploy into
  - vpn_app_id - ID of the VPN Enterprise Application, see https://learn.microsoft.com/en-us/azure/vpn-gateway/openvpn-azure-ad-tenant
\ No newline at end of file
diff --git a/Terraform-Cloud-Labs/.gitignore b/Terraform-Cloud-Labs/.gitignore
deleted file mode 100644
index bddcb25..0000000
--- a/Terraform-Cloud-Labs/.gitignore
+++ /dev/null
@@ -1,33 +0,0 @@
-# Local .terraform directories
-**/.terraform/*
-
-# .tfstate files
-*.tfstate
-*.tfstate.*
-
-# Crash log files
-crash.log
-crash.*.log
-
-# Exclude all .tfvars files, which are likely to contain sensitive data, such as
-# password, private keys, and other secrets. These should not be part of version 
-# control as they are data points which are potentially sensitive and subject 
-# to change depending on the environment.
-
-# Ignore override files as they are usually used to override resources locally and so
-# are not checked in
-override.tf
-override.tf.json
-*_override.tf
-*_override.tf.json
-
-# Include override files you do wish to add to version control using negated pattern
-# !example_override.tf
-
-# Include tfplan files to ignore the plan output of command: terraform plan -out=tfplan
-# example: *tfplan*
-
-# Ignore CLI configuration files
-.terraformrc
-terraform.rc
-.terraform.lock.hcl