chore(ast): clang compiler improvements

Author: jahan-addison

roxas/ast.h

@@ -180,70 +180,70 @@ class lvalue_node final : public node
 };
 
 /**
- * @brief The expression node
+ * @brief The rvalue node
  *
- * An expression can be one or many of an lvalue, or rvalue
+ * Holds a pointer to its data expression
  *
  */
-class expression_node final : public node
+class rvalue_node final : public node
 {
   public:
-    using datatype =
-        std::vector<std::variant<std::monostate, lvalue_node, rvalue_node>>;
     /**
-     * @brief Construct a new expression node
+     * @brief Construct a new rvalue node
      *
-     * @param type expression type, per the grammar
-     * @param expr the lvalue or rvalue of the expression
+     * @param type rvalue type, per te grammar
+     * @param node the rvalue expression
      */
-    explicit expression_node(std::string type, datatype expr)
+    explicit rvalue_node(std::string type, std::string rvalue)
         : type_(std::move(type))
-        , expr_(std::move(expr))
+        , rvalue_(std::move(rvalue))
+
     {
     }
 
     /**
-     * @brief The expression node print function
+     * @brief The rvalue node print function
      *
      */
     void print() const override;
 
   private:
     std::string type_;
-    datatype expr_;
+    std::string rvalue_;
 };
 
 /**
- * @brief The rvalue node
+ * @brief The expression node
  *
- * Holds a pointer to its data expression
+ * An expression can be one or many of an lvalue, or rvalue
  *
  */
-class rvalue_node final : public node
+class expression_node final : public node
 {
   public:
+    using datatype =
+        std::vector<std::variant<std::monostate, lvalue_node, rvalue_node>>;
     /**
-     * @brief Construct a new rvalue node
+     * @brief Construct a new expression node
      *
-     * @param type rvalue type, per te grammar
-     * @param node the rvalue expression
+     * @param type expression type, per the grammar
+     * @param expr the lvalue or rvalue of the expression
      */
-    explicit rvalue_node(std::string type, std::string rvalue)
+    explicit expression_node(std::string type, datatype expr)
         : type_(std::move(type))
-        , rvalue_(std::move(rvalue))
-
+        , expr_(std::move(expr))
     {
     }
 
     /**
-     * @brief The rvalue node print function
+     * @brief The expression node print function
      *
      */
     void print() const override;
 
   private:
     std::string type_;
-    std::string rvalue_;
+    datatype expr_;
 };
 
 /**
@@ -286,5 +286,4 @@ class statement_node final : public node
 };
 
 } // namespace ast
-
 } // namespace roxas