Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bookmark/history size limit #111

Open
niktss opened this issue Sep 19, 2020 · 11 comments
Open

Remove bookmark/history size limit #111

niktss opened this issue Sep 19, 2020 · 11 comments

Comments

@niktss
Copy link

niktss commented Sep 19, 2020

It's just a text file I'm assuming - even a full book is just megabytes, so storage isn't a concern.

@soshial
Copy link

soshial commented Jan 15, 2023

I am also very interested in unlimited bookmark/history? Why any limitations?

@itkach
Copy link
Owner

itkach commented Jan 18, 2023

storage is not a concern, but lookup and update speed, as well as filtering and sorting in ui are. Perhaps current limit of a hundred items is conservative and could be higher, but to remove it entirely requires a more sophisticated storage implementation.

@ildar
Copy link

ildar commented Aug 19, 2023 via email

@ildar
Copy link

ildar commented Aug 19, 2023 via email

@niktss
Copy link
Author

niktss commented Aug 19, 2023

I like Aard very much and use it since aard1 times. But this limitation spoils the whole idea of using it as a dictionary app (I guess that wiki-type users do not care) Losing data disappoints me a lot. In this case the words I learn & bookmark. Would you please raise the limit as a 1st step? E.g. 1000 looks like a good compromise.

There already is a Material UI fork with 1000 as limit; the name escapes me however. The icon was cat themed or something.

@ildar
Copy link

ildar commented Aug 20, 2023 via email

@ildar
Copy link

ildar commented Aug 20, 2023

Screenshot_20230820-120149_Duolingo

@ildar
Copy link

ildar commented Oct 8, 2023 via email

@MuntashirAkon
Copy link

Aard 2 uses individual files instead of a database for storing history, bookmarks, and dictionary info. This means all the files has to be loaded in a list before they can be displayed. This can be problematic for several reasons:

  1. Reading individual files is slower than reading a single file. Adding support for 1,000 entries, for example, can increase the loading time.
  2. There's a possibility of MemoryOutOfBound error if the list is too long (say, 10,000 entries). It's likely that a user will always add bookmarks and never delete them. This implies adding additional features such as deleting bookmarks by their usage which is too complicated for a dictionary app.

@ildar: The image you shared (from Duolingo, I believe) has usage for learning apps (like Duolingo or Anki), but not Aard 2 which is a dictionary app.

@ildar
Copy link

ildar commented Dec 20, 2024 via email

@niktss
Copy link
Author

niktss commented Dec 20, 2024

Ideally we will have something like sqlite, but if not, I would say let us power users deal with the loading times. And further down the line someone might contribute an sqlite implementation if they get sufficiently annoyed at the speed, but at the moment people don't even realise there's a limit until months into usage, and only once they realise they've bookmarked something before but it doesn't show up as such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants