Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTFSWriter creates empty files for empty entity sets #69

Open
mmsatari opened this issue Apr 8, 2020 · 3 comments
Open

GTFSWriter creates empty files for empty entity sets #69

mmsatari opened this issue Apr 8, 2020 · 3 comments

Comments

@mmsatari
Copy link

mmsatari commented Apr 8, 2020

When you write a feed to some path, it creates empty files for the entity sets that contain no items. I would be better not to create these files at all.
@mmsatari
Copy link
Author

mmsatari commented Apr 8, 2020

I can fix this if you don't mind.

@xivk
Copy link
Contributor

xivk commented Apr 8, 2020

Sure, please do! Try to minimize the amount of code that changes and changes to coding styles and you should be good.

@mmsatari
Copy link
Author

mmsatari commented Apr 9, 2020

Thank you. I noticed in my last PR I missed a space (styling issue :D) but if you have told me, I would have happily fix that. Next time please do ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xivk @mmsatari