From b6941470ace0d592079a062101945076f07c7bc8 Mon Sep 17 00:00:00 2001 From: Mitch Connors Date: Fri, 17 Jan 2025 15:08:55 -0800 Subject: [PATCH 1/2] improve documentation for tag and rev label --- label/labels.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/label/labels.yaml b/label/labels.yaml index f3861d667a..d144c5bd4d 100644 --- a/label/labels.yaml +++ b/label/labels.yaml @@ -61,20 +61,22 @@ labels: - WorkloadEntry - name: istio.io/rev - featureStatus: Alpha - description: Istio control plane revision associated with the resource; e.g. `canary` + featureStatus: Beta + description: Istio control plane revision or tag associated with the resource; e.g. `canary` hidden: false deprecated: false resources: - Namespace + - Gateway + - Pod - name: istio.io/tag featureStatus: Alpha - description: Istio control plane tag name associated with the resource; e.g. `canary` + description: Istio control plane tag name associated with the resource - for internal use only hidden: false deprecated: false resources: - - Namespace + - MutatingWebhookConfiguration - name: operator.istio.io/component featureStatus: Alpha From efce25bb5721a41d03c5fb825c49a0b29348958b Mon Sep 17 00:00:00 2001 From: Mitch Connors Date: Tue, 21 Jan 2025 10:40:17 -0800 Subject: [PATCH 2/2] make gen --- label/labels.gen.go | 28 +++++++++++++++++----------- label/labels.pb.html | 10 +++++----- 2 files changed, 22 insertions(+), 16 deletions(-) diff --git a/label/labels.gen.go b/label/labels.gen.go index 57111ec123..d013d2e075 100644 --- a/label/labels.gen.go +++ b/label/labels.gen.go @@ -31,6 +31,7 @@ const ( Deployment Gateway GatewayClass + MutatingWebhookConfiguration Namespace Node Pod @@ -51,18 +52,20 @@ func (r ResourceTypes) String() string { case 4: return "GatewayClass" case 5: - return "Namespace" + return "MutatingWebhookConfiguration" case 6: - return "Node" + return "Namespace" case 7: - return "Pod" + return "Node" case 8: - return "Service" + return "Pod" case 9: - return "ServiceAccount" + return "Service" case 10: - return "ServiceEntry" + return "ServiceAccount" case 11: + return "ServiceEntry" + case 12: return "WorkloadEntry" } return "Unknown" @@ -142,25 +145,27 @@ Note: users wishing to use sidecar mode should see the "istio-injection" label; IoIstioRev = Instance { Name: "istio.io/rev", - Description: "Istio control plane revision associated with the "+ + Description: "Istio control plane revision or tag associated with the "+ "resource; e.g. `canary`", - FeatureStatus: Alpha, + FeatureStatus: Beta, Hidden: false, Deprecated: false, Resources: []ResourceTypes{ Namespace, + Gateway, + Pod, }, } IoIstioTag = Instance { Name: "istio.io/tag", - Description: "Istio control plane tag name associated with the "+ - "resource; e.g. `canary`", + Description: "Istio control plane tag name associated with the resource "+ + "- for internal use only", FeatureStatus: Alpha, Hidden: false, Deprecated: false, Resources: []ResourceTypes{ - Namespace, + MutatingWebhookConfiguration, }, } @@ -461,6 +466,7 @@ func AllResourceTypes() []string { "Deployment", "Gateway", "GatewayClass", + "MutatingWebhookConfiguration", "Namespace", "Node", "Pod", diff --git a/label/labels.pb.html b/label/labels.pb.html index 148b648cf7..cc4c2940e1 100644 --- a/label/labels.pb.html +++ b/label/labels.pb.html @@ -86,15 +86,15 @@

istio.io/rev

Feature Status - Alpha + Beta Resource Types - [Namespace] + [Namespace Gateway Pod] Description -

Istio control plane revision associated with the resource; e.g. canary

+

Istio control plane revision or tag associated with the resource; e.g. canary

@@ -112,11 +112,11 @@

istio.io/tag

Resource Types - [Namespace] + [MutatingWebhookConfiguration] Description -

Istio control plane tag name associated with the resource; e.g. canary

+

Istio control plane tag name associated with the resource - for internal use only